From d429cbd0e4d86d4af54ed50e499da14039ff7429 Mon Sep 17 00:00:00 2001 From: Andreas Hasenack Date: Mon, 10 Sep 2018 19:40:55 +0000 Subject: [PATCH] Fix basic_pop3_auth startup errors (#284) 90cf12e added "use strict" which requires declaring all variables. Originally reported (against Squid v3) at https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1755189 --- src/auth/basic/POP3/basic_pop3_auth.pl.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/auth/basic/POP3/basic_pop3_auth.pl.in b/src/auth/basic/POP3/basic_pop3_auth.pl.in index f821f62e9c..5ba458bbf5 100755 --- a/src/auth/basic/POP3/basic_pop3_auth.pl.in +++ b/src/auth/basic/POP3/basic_pop3_auth.pl.in @@ -89,14 +89,14 @@ if ( @ARGV != 1 ) { exit 1 } -$server = shift @ARGV; +my $server = shift @ARGV; while(<>) { my ($username, $password) = split(/\s+/); $username =~ s/%([0-9a-f][0-9a-f])/pack("H2",$1)/gie; $password =~ s/%([0-9a-f][0-9a-f])/pack("H2",$1)/gie; - $pop = Net::POP3->new($server); + my $pop = Net::POP3->new($server); if (!$pop) { print "ERR Server not responding\n"; next; -- 2.47.2