From d83de8e8870772b7a7bc23046ac6ebf3b4406e4e Mon Sep 17 00:00:00 2001 From: Marek Schimara Date: Thu, 16 Jun 2016 15:54:17 +0200 Subject: [PATCH] src/rrd_graph.c: fix Coverity CID#26514 Buffer not null terminated CWE-170 / https://cwe.mitre.org/data/definitions/170.html --- src/rrd_graph.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/rrd_graph.c b/src/rrd_graph.c index 89024adf..c0c01877 100644 --- a/src/rrd_graph.c +++ b/src/rrd_graph.c @@ -2090,7 +2090,8 @@ int leg_place( for (i = 0; i < im->gdes_c; i++) { char prt_fctn; /*special printfunctions */ if(calc_width){ - strncpy(saved_legend, im->gdes[i].legend, sizeof saved_legend); + strncpy(saved_legend, im->gdes[i].legend, sizeof saved_legend - 1); + saved_legend[sizeof saved_legend - 1] = '\0'; } fill_last = fill; @@ -2256,7 +2257,8 @@ int leg_place( } if(calc_width){ - strncpy(im->gdes[i].legend, saved_legend, sizeof im->gdes[0].legend); + strncpy(im->gdes[i].legend, saved_legend, sizeof im->gdes[0].legend - 1); + im->gdes[i].legend[sizeof im->gdes[0].legend - 1] = '\0'; } } -- 2.47.2