From e5a47d76165a88fc0d04c3e08a2fee96bd9409db Mon Sep 17 00:00:00 2001 From: Juliana Fajardini Date: Sat, 10 May 2025 16:35:08 -0300 Subject: [PATCH] pgsql: rename 'dummy' response variables While this could be considered minor, they were not just bad, but misleading names, as the variables weren't really `dummy` responses, but consolidating several messages. --- rust/src/pgsql/pgsql.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rust/src/pgsql/pgsql.rs b/rust/src/pgsql/pgsql.rs index 52300dc80a..7dcbe6497d 100644 --- a/rust/src/pgsql/pgsql.rs +++ b/rust/src/pgsql/pgsql.rs @@ -638,14 +638,14 @@ impl PgsqlState { && tx.get_row_cnt() > 0 { // let's summarize the info from the data_rows in one response - let dummy_resp = PgsqlBEMessage::ConsolidatedDataRow( + let consolidated_data_row = PgsqlBEMessage::ConsolidatedDataRow( ConsolidatedDataRowPacket { identifier: b'D', row_cnt: tx.get_row_cnt(), data_size: tx.data_size, // total byte count of all data_row messages combined }, ); - tx.responses.push(dummy_resp); + tx.responses.push(consolidated_data_row); tx.responses.push(response); // reset values tx.data_row_cnt = 0; @@ -654,14 +654,14 @@ impl PgsqlState { tx.incr_row_cnt(); } else if state == PgsqlStateProgress::CopyDoneReceived && tx.get_row_cnt() > 0 { // let's summarize the info from the data_rows in one response - let dummy_resp = PgsqlBEMessage::ConsolidatedCopyDataOut( + let consolidated_copy_data = PgsqlBEMessage::ConsolidatedCopyDataOut( ConsolidatedDataRowPacket { identifier: b'd', row_cnt: tx.get_row_cnt(), data_size: tx.data_size, // total byte count of all data_row messages combined }, ); - tx.responses.push(dummy_resp); + tx.responses.push(consolidated_copy_data); tx.responses.push(response); // reset values tx.data_row_cnt = 0; -- 2.47.2