From e640ffda5b59ac9de048b39ff46dcdd88f6ad832 Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Sat, 8 Aug 2020 20:02:01 +0100 Subject: [PATCH] lib/pager: fix improper use of negative value [coverity scan] The close(2) cannot accept a negative number. CID: 360777 Signed-off-by: Sami Kerola --- lib/pager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pager.c b/lib/pager.c index b3cf6ee79b..747521e137 100644 --- a/lib/pager.c +++ b/lib/pager.c @@ -88,14 +88,14 @@ static int start_command(struct child_process *cmd) if (cmd->pid < 0) { if (need_in) close_pair(fdin); - else if (cmd->in) + else if (0 <= cmd->in) close(cmd->in); return -1; } if (need_in) close(fdin[0]); - else if (cmd->in) + else if (0 <= cmd->in) close(cmd->in); return 0; } -- 2.47.2