From f28e9ae9be922e53f65740cf0598a8a2177c1b66 Mon Sep 17 00:00:00 2001 From: Marek Schimara Date: Fri, 17 Jun 2016 09:45:28 +0200 Subject: [PATCH] src/rrd_open.c: fix Coverity CID#13676 Dereference before null check CWE-476 / https://cwe.mitre.org/data/definitions/476.html --- src/rrd_open.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rrd_open.c b/src/rrd_open.c index 3bb27266..ec4ae2e0 100644 --- a/src/rrd_open.c +++ b/src/rrd_open.c @@ -586,7 +586,7 @@ void rrd_dontneed( rrd_file_t *rrd_file, rrd_t *rrd) { - rrd_simple_file_t *rrd_simple_file = (rrd_simple_file_t *)rrd_file->pvt; + rrd_simple_file_t *rrd_simple_file; #if defined USE_MADVISE || defined HAVE_POSIX_FADVISE size_t dontneed_start; size_t rra_start; @@ -600,6 +600,7 @@ void rrd_dontneed( #endif return; } + rrd_simple_file = (rrd_simple_file_t *)rrd_file->pvt; #if defined DEBUG && DEBUG > 1 mincore_print(rrd_file, "before"); -- 2.47.2