From f74e41bbf022280c8a7e26fb86d0fb3a5e3634cc Mon Sep 17 00:00:00 2001 From: Francesco Chemolli Date: Fri, 6 May 2022 14:09:23 +0000 Subject: [PATCH] Initialise default_keytab in negotiate_kerberos_auth (#1032) Address a Coverity-identified issue, where default_keytab might be read when uninitialised in negotiate_kerberos_auth. Ensure it is initialised at declaration. Detected by Coverity, CID 1503291 (Uninitialized scalar variable) --- src/auth/negotiate/kerberos/negotiate_kerberos_auth.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/auth/negotiate/kerberos/negotiate_kerberos_auth.cc b/src/auth/negotiate/kerberos/negotiate_kerberos_auth.cc index 0b38be7bf3..3e66109970 100644 --- a/src/auth/negotiate/kerberos/negotiate_kerberos_auth.cc +++ b/src/auth/negotiate/kerberos/negotiate_kerberos_auth.cc @@ -349,7 +349,7 @@ main(int argc, char *const argv[]) char *service_principal = NULL; char *keytab_name = NULL; char *keytab_name_env = NULL; - char default_keytab[MAXPATHLEN]; + char default_keytab[MAXPATHLEN] = {}; #if HAVE_KRB5_MEMORY_KEYTAB char *memory_keytab_name = NULL; char *memory_keytab_name_env = NULL; -- 2.47.2