From f9a2e8a38f524c04fc493548303488dc180b25bd Mon Sep 17 00:00:00 2001 From: Mark Levedahl Date: Fri, 2 May 2025 11:39:55 -0400 Subject: [PATCH] git-gui: remove HEAD detachment implementation for git < 1.5.3 git-gui provides an implementation to detach HEAD on Git versions prior to 1.5.3. Nobody should be using such an old version anymore. (Moreover, since 0730a5a3a, git-gui requires git v2.36 or later). Keep only the code for modern Git. Signed-off-by: Mark Levedahl [j6t: message tweaked] Signed-off-by: Johannes Sixt Signed-off-by: Taylor Blau --- lib/checkout_op.tcl | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/lib/checkout_op.tcl b/lib/checkout_op.tcl index 21ea768d80..5f7011078a 100644 --- a/lib/checkout_op.tcl +++ b/lib/checkout_op.tcl @@ -510,18 +510,8 @@ method _update_repo_state {} { delete_this } -git-version proc _detach_HEAD {log new} { - >= 1.5.3 { - git update-ref --no-deref -m $log HEAD $new - } - default { - set p [gitdir HEAD] - file delete $p - set fd [open $p w] - fconfigure $fd -translation lf -encoding utf-8 - puts $fd $new - close $fd - } +proc _detach_HEAD {log new} { + git update-ref --no-deref -m $log HEAD $new } method _confirm_reset {cur} { -- 2.47.2