From fc1671c6801ac9eaa94ee10edcb02e08e25ee6ff Mon Sep 17 00:00:00 2001
From: Tomek Mrugalski <tomasz@isc.org>
Date: Tue, 15 Jan 2019 14:21:30 +0100
Subject: [PATCH] [#283,!135] Changes after review: PktPtr moved to dhcp/pkt.h

---
 src/bin/perfdhcp/receiver.cc | 12 ++++++------
 src/bin/perfdhcp/receiver.h  | 11 ++++-------
 src/lib/dhcp/pkt.h           |  3 +++
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/bin/perfdhcp/receiver.cc b/src/bin/perfdhcp/receiver.cc
index 1eb5d9f284..adbf905c85 100644
--- a/src/bin/perfdhcp/receiver.cc
+++ b/src/bin/perfdhcp/receiver.cc
@@ -118,14 +118,14 @@ Receiver::readPktFromSocket() {
     } catch (const Exception& e) {
         cerr << "Failed to receive DHCP packet: " << e.what() << endl;
     }
-    if (!pkt) {
-        return nullptr;
+
+    if (pkt) {
+        /// @todo: Add packet exception handling here. Right now any
+        /// malformed packet will cause perfdhcp to abort.
+        pkt->unpack();
     }
 
-    /// @todo: Add packet exception handling here. Right now any
-    /// malformed packet will cause perfdhcp to abort.
-    pkt->unpack();
-    return pkt;
+    return (pkt);
 }
 
 void
diff --git a/src/bin/perfdhcp/receiver.h b/src/bin/perfdhcp/receiver.h
index a2ed33360e..482972c756 100644
--- a/src/bin/perfdhcp/receiver.h
+++ b/src/bin/perfdhcp/receiver.h
@@ -10,8 +10,7 @@
 #include <perfdhcp/better_socket.h>
 #include <perfdhcp/command_options.h>
 
-#include <dhcp/pkt4.h>
-#include <dhcp/pkt6.h>
+#include <dhcp/pkt.h>
 #include <util/threads/thread.h>
 
 #include <queue>
@@ -22,8 +21,6 @@
 namespace isc {
 namespace perfdhcp {
 
-typedef boost::shared_ptr<isc::dhcp::Pkt> PktPtr;
-
 /// \brief A receviving DHCP packets class.
 ///
 /// Receiver can be used in two modes: single-thread and multi-thread.
@@ -48,7 +45,7 @@ private:
     std::unique_ptr<util::thread::Thread> recv_thread_;
 
     /// \brief Queue for passing packets from receiver thread to main thread.
-    std::queue<PktPtr> pkt_queue_;
+    std::queue<dhcp::PktPtr> pkt_queue_;
 
     /// \brief Mutex for controlling access to the queue.
     std::mutex pkt_queue_mutex_;
@@ -82,7 +79,7 @@ public:
     ///
     /// In single-thread mode it reads directly from the socket.
     /// In multi-thread mode it reads packets from the queue.
-    PktPtr getPkt();
+    dhcp::PktPtr getPkt();
 
 private:
     /// \brief Receiving thread main function.
@@ -94,7 +91,7 @@ private:
     void receivePackets();
 
     /// \brief Read a packet directly from the socket.
-    PktPtr readPktFromSocket();
+    dhcp::PktPtr readPktFromSocket();
 };
 
 }
diff --git a/src/lib/dhcp/pkt.h b/src/lib/dhcp/pkt.h
index 53ab96a6c7..cf90eb4073 100644
--- a/src/lib/dhcp/pkt.h
+++ b/src/lib/dhcp/pkt.h
@@ -785,6 +785,9 @@ private:
                                  HWAddrPtr& storage);
 };
 
+/// @brief A pointer to either Pkt4 or Pkt6 packet
+typedef boost::shared_ptr<isc::dhcp::Pkt> PktPtr;
+
 }; // namespace isc::dhcp
 }; // namespace isc
 
-- 
2.47.2