From fde13960b97c664d754cdef04f4de63c14240c05 Mon Sep 17 00:00:00 2001 From: Geoffrey Keating Date: Mon, 16 Oct 2000 18:08:29 +0000 Subject: [PATCH] From 2000-10-14 Geoffrey Keating * elf32-ppc.c (ppc_elf_finish_dynamic_symbol): Don't make PLT entries that could serve as a definition for a weak symbol. --- bfd/ChangeLog | 6 ++++++ bfd/elf32-ppc.c | 7 +++++++ 2 files changed, 13 insertions(+) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 7659ec68400..e510060f991 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2000-10-16 Geoffrey Keating + + From 2000-10-14 Geoffrey Keating + * elf32-ppc.c (ppc_elf_finish_dynamic_symbol): Don't make PLT + entries that could serve as a definition for a weak symbol. + 2000-10-15 Philip Blundell From 2000-09-08 Nick Clifton diff --git a/bfd/elf32-ppc.c b/bfd/elf32-ppc.c index 242cfb730ab..e648f0256c2 100644 --- a/bfd/elf32-ppc.c +++ b/bfd/elf32-ppc.c @@ -2687,6 +2687,13 @@ ppc_elf_finish_dynamic_symbol (output_bfd, info, h, sym) /* Mark the symbol as undefined, rather than as defined in the .plt section. Leave the value alone. */ sym->st_shndx = SHN_UNDEF; + /* If the symbol is weak, we do need to clear the value. + Otherwise, the PLT entry would provide a definition for + the symbol even if the symbol wasn't defined anywhere, + and so the symbol would never be NULL. */ + if ((h->elf_link_hash_flags & ELF_LINK_HASH_REF_REGULAR_NONWEAK) + == 0) + sym->st_value = 0; } } -- 2.47.2