From 52bf406d583769adc2a77a4d223c110411529786 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Vladim=C3=ADr=20=C4=8Cun=C3=A1t?= Date: Tue, 19 Nov 2024 08:42:44 +0100 Subject: [PATCH] daemon/worker: decrease log level of uv_udp_connect() failure In particular, ENETUNREACH happens on systems without IPv6, and it doesn't make much sense to log about that by default: [io ] Failed to establish udp connection: address not available Introduced in 82e1d596 (v6.0.9). Also log the IP address. --- NEWS | 8 ++++++++ daemon/worker.c | 6 ++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 6e66c5904..6b86a803f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,11 @@ +Knot Resolver 6.0.10 (202y-mm-dd) +================================ + +Improvements +------------ +- avoid multiple log lines when IPv6 isn't available (!1633) + + Knot Resolver 6.0.9 (2024-11-11) ================================ diff --git a/daemon/worker.c b/daemon/worker.c index c14f927f8..d517dd6c2 100644 --- a/daemon/worker.c +++ b/daemon/worker.c @@ -838,8 +838,10 @@ static int transmit(struct qr_task *task) do { ret = uv_udp_connect(udp, out_comm.comm_addr); } while (ret == UV_EADDRINUSE && --connect_tries > 0); - if (ret < 0) - kr_log_error(IO, "Failed to establish udp connection: %s\n", uv_strerror(ret)); + if (ret < 0) { + kr_log_info(IO, "Failed to establish udp connection to %s: %s\n", + kr_straddr(out_comm.comm_addr), uv_strerror(ret)); + } } ret = qr_task_send(task, session, &out_comm, task->pktbuf); if (ret) { -- 2.47.2