From c333430516caec4faeccb2a20fef18c8ea4cb71b Mon Sep 17 00:00:00 2001 From: Miod Vallat Date: Mon, 18 Aug 2025 09:40:30 +0200 Subject: [PATCH] Deserialize bool variables as bool. Signed-off-by: Miod Vallat --- modules/lmdbbackend/lmdbbackend.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc index bfac4816b..eb111ae7d 100644 --- a/modules/lmdbbackend/lmdbbackend.cc +++ b/modules/lmdbbackend/lmdbbackend.cc @@ -1072,14 +1072,16 @@ static inline size_t deserializeRRFromBuffer(const string_view& str, LMDBBackend if (str.size() < serialize_prefix_size + len + serialize_trailing_size) { return 0; } + // NOLINTBEGIN(cppcoreguidelines-pro-bounds-pointer-arithmetic): due to the above size check, this is safe data += sizeof(len); lrr.content.assign(data, len); // len bytes data += len; memcpy(&lrr.ttl, data, sizeof(uint32_t)); data += sizeof(uint32_t); - lrr.auth = *data++; - lrr.disabled = *data++; + lrr.auth = *data++ != 0; + lrr.disabled = *data++ != 0; lrr.hasOrderName = *data++ != 0; + // NOLINTEND(cppcoreguidelines-pro-bounds-pointer-arithmetic) lrr.wildcardname.clear(); return data - str.data(); -- 2.47.2