From 091e3596126ade0b190d0993b8b67c5ad3fb7a9f Mon Sep 17 00:00:00 2001 From: Kees Monshouwer Date: Wed, 22 Apr 2015 20:47:04 +0200 Subject: [PATCH] add some missing toLower() and add a test for makeRelative() --- pdns/backends/gsql/gsqlbackend.cc | 6 +++--- pdns/test-misc_hh.cc | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/pdns/backends/gsql/gsqlbackend.cc b/pdns/backends/gsql/gsqlbackend.cc index 7c6b6c892b..f6b259ffc6 100644 --- a/pdns/backends/gsql/gsqlbackend.cc +++ b/pdns/backends/gsql/gsqlbackend.cc @@ -372,7 +372,7 @@ bool GSQLBackend::updateDNSSECOrderAndAuthAbsolute(uint32_t domain_id, const std return false; char output[1024]; - snprintf(output, sizeof(output)-1, d_setOrderAuthQuery.c_str(), sqlEscape(ordername).c_str(), auth, sqlEscape(qname).c_str(), domain_id); + snprintf(output, sizeof(output)-1, d_setOrderAuthQuery.c_str(), sqlEscape(ordername).c_str(), auth, sqlEscape(toLower(qname)).c_str(), domain_id); try { d_db->doCommand(output); } @@ -388,7 +388,7 @@ bool GSQLBackend::nullifyDNSSECOrderNameAndUpdateAuth(uint32_t domain_id, const return false; char output[1024]; - snprintf(output, sizeof(output)-1, d_nullifyOrderNameAndUpdateAuthQuery.c_str(), auth, domain_id, sqlEscape(qname).c_str()); + snprintf(output, sizeof(output)-1, d_nullifyOrderNameAndUpdateAuthQuery.c_str(), auth, domain_id, sqlEscape(toLower(qname)).c_str()); try { d_db->doCommand(output); } @@ -404,7 +404,7 @@ bool GSQLBackend::nullifyDNSSECOrderNameAndAuth(uint32_t domain_id, const std::s return false; char output[1024]; - snprintf(output, sizeof(output)-1, d_nullifyOrderNameAndAuthQuery.c_str(), sqlEscape(qname).c_str(), sqlEscape(type).c_str(), domain_id); + snprintf(output, sizeof(output)-1, d_nullifyOrderNameAndAuthQuery.c_str(), sqlEscape(toLower(qname)).c_str(), sqlEscape(type).c_str(), domain_id); try { d_db->doCommand(output); } diff --git a/pdns/test-misc_hh.cc b/pdns/test-misc_hh.cc index 8732264f3e..9d495a2da2 100644 --- a/pdns/test-misc_hh.cc +++ b/pdns/test-misc_hh.cc @@ -110,6 +110,7 @@ BOOST_AUTO_TEST_CASE(test_labelReverse) { BOOST_AUTO_TEST_CASE(test_makeRelative) { BOOST_CHECK_EQUAL(makeRelative("www.powerdns.com", "powerdns.com"), "www"); + BOOST_CHECK_EQUAL(makeRelative("PoWeRdNs.CoM", "powerdns.com"), ""); } BOOST_AUTO_TEST_CASE(test_AtomicCounter) { -- 2.47.2