From ebf610b14fe92ef2255d4b9cbf761df388c48e2d Mon Sep 17 00:00:00 2001 From: =?utf8?q?H=C3=A5kan=20Lindqvist?= Date: Thu, 20 Jun 2019 22:57:45 +0200 Subject: [PATCH] Minor fixes to dnsdist docs DNSQType was introduced in 1.4.0, not 1.3.0 Typo in AXFR example (DNSQTypeIXFR) --- pdns/dnsdistdist/docs/advanced/axfr.rst | 4 ++-- pdns/dnsdistdist/docs/reference/constants.rst | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pdns/dnsdistdist/docs/advanced/axfr.rst b/pdns/dnsdistdist/docs/advanced/axfr.rst index dc883b85ce..4d9372a81a 100644 --- a/pdns/dnsdistdist/docs/advanced/axfr.rst +++ b/pdns/dnsdistdist/docs/advanced/axfr.rst @@ -18,7 +18,7 @@ The first issue can be solved by routing SOA, AXFR and IXFR requests explicitly The second one might require allowing AXFR/IXFR from the :program:`dnsdist` source address and moving the source address check to :program:`dnsdist`'s side:: - addAction(AndRule({OrRule({QTypeRule(DNSQType.AXFR), QTypeRule(DNSQTypeIXFR)}), NotRule(makeRule("192.168.1.0/24"))}), RCodeAction(DNSRCode.REFUSED)) + addAction(AndRule({OrRule({QTypeRule(DNSQType.AXFR), QTypeRule(DNSQType.IXFR)}), NotRule(makeRule("192.168.1.0/24"))}), RCodeAction(DNSRCode.REFUSED)) .. versionchanged:: 1.4.0 Before 1.4.0, the QTypes were in the ``dnsdist`` namespace. Use ``dnsdist.AXFR`` and ``dnsdist.IXFR`` in these versions. @@ -33,4 +33,4 @@ check to :program:`dnsdist`'s side:: addAction(AndRule({OpcodeRule(DNSOpcode.Notify), NotRule(makeRule("192.168.1.0/24"))}), RCodeAction(DNSRCode.REFUSED)) .. versionchanged:: 1.4.0 - Before 1.4.0, the RCodes were in the ``dnsdist`` namespace. Use ``dnsdist.REFUSED`` in these versions. \ No newline at end of file + Before 1.4.0, the RCodes were in the ``dnsdist`` namespace. Use ``dnsdist.REFUSED`` in these versions. diff --git a/pdns/dnsdistdist/docs/reference/constants.rst b/pdns/dnsdistdist/docs/reference/constants.rst index 4df9586a49..1ead1ec82e 100644 --- a/pdns/dnsdistdist/docs/reference/constants.rst +++ b/pdns/dnsdistdist/docs/reference/constants.rst @@ -123,7 +123,7 @@ These constants represent an Action that can be returned from :func:`LuaAction` DNSQType -------- -.. versionchanged:: 1.3.0 +.. versionchanged:: 1.4.0 The prefix is changed from ``dnsdist.`` to ``DNSQType``. All named `QTypes `__ are available as constants, prefixed with ``DNSQType.``, e.g.: -- 2.47.2