]> git.ipfire.org Git - thirdparty/git.git/commit
odb/source-loose: drop `odb_source_loose_has_object()`
authorPatrick Steinhardt <ps@pks.im>
Mon, 1 Jun 2026 08:20:34 +0000 (10:20 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 1 Jun 2026 09:47:18 +0000 (18:47 +0900)
commit86f7ab5a1f12ecfdf51b6df0b9b014e2329944be
tree91f65a833c03f52d7a0b456c1c962a934efa1122
parent2ade08ac2978dc1c908602c2a4d653836ecb5acb
odb/source-loose: drop `odb_source_loose_has_object()`

The function `odb_source_loose_has_object()` checks whether a specific
object exists as a loose object on disk by using lstat(3p). This
interface is somewhat redundant, as we typically check for object
existence in a generic way via `odb_source_read_object_info()`.

In fact, these two calls are redundant in case the latter is called in a
specific way: when called without an object info request and without the
`OBJECT_INFO_QUICK` flag, then we will end up doing the same call to
lstat(3p) in `read_object_info_from_path()`.

Drop the function and adapt callers to instead use the generic
interface so that its calling conventions align with that of other
sources.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/pack-objects.c
object-file.c
object-file.h