]> git.ipfire.org Git - thirdparty/linux.git/commit
clk: rockchip: rk3588: don't disable unused I2S MCLK output gates
authorDaniele Briguglio <hello@superkali.me>
Wed, 24 Jun 2026 12:39:14 +0000 (14:39 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Sun, 28 Jun 2026 19:09:50 +0000 (21:09 +0200)
commit946352b2f88fd2378f0341312e47dff1e8dc2fac
treec87b14a64f599eef40b36556d35561158c33e760
parentdc59e4fea9d83f03bad6bddf3fa2e52491777482
clk: rockchip: rk3588: don't disable unused I2S MCLK output gates

No in-tree board references these gates yet. Boards drive the codec
MCLK through the parent I2S*_8CH_MCLKOUT, and now that the gates are
managed clocks, clk_disable_unused() turns them off at boot. On a board
that relied on firmware leaving the output enabled, that cuts the MCLK
and analog audio stops working.

Mark the four gates CLK_IGNORE_UNUSED so an unreferenced gate keeps the
state firmware left. A board that wants the kernel to own the gate can
reference I2S*_8CH_MCLKOUT_TO_IO from DT instead.

Fixes: 02b9b0bb6269 ("clk: rockchip: rk3588: add GATE_GRF clocks for I2S MCLK output to IO")
Reported-by: Diederik de Haas <diederik@cknow-tech.com>
Closes: https://lore.kernel.org/linux-rockchip/DJGDSS875DDO.22TYPVYK5X8KZ@cknow-tech.com/
Tested-by: Diederik de Haas <diederik@cknow-tech.com>
Signed-off-by: Daniele Briguglio <hello@superkali.me>
Tested-by: Ricardo Pardini <ricardo@pardini.net> # on R58X-Pro+NanoPC-T6
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Link: https://patch.msgid.link/20260624123914.1767374-1-hello@superkali.me
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
drivers/clk/rockchip/clk-rk3588.c