]> git.ipfire.org Git - thirdparty/linux.git/commit
fs: Fix possible UAF in mark_buffer_write_io_error()
authorJan Kara <jack@suse.cz>
Mon, 27 Jul 2026 10:49:20 +0000 (12:49 +0200)
committerChristian Brauner <brauner@kernel.org>
Mon, 27 Jul 2026 14:25:31 +0000 (16:25 +0200)
commitb0bca4e95b03438cd2c20bb7be3e6e109d1a01fa
treef90b8646ec3c1d69a355415cee2b5db54e6eebc4
parentb637f52f2f265b001834c5efcc6e1d7165ca52f7
fs: Fix possible UAF in mark_buffer_write_io_error()

When filesystem is freeing inode it calls mmb_invalidate() which removes
bhs from inode's metadata bh tracking and clears b_mmb for them. However
if the inode is getting deleted, we don't bother with calling mmb_sync()
before and thus these buffers can be under IO and we can be racing with
IO completion handler calling mark_buffer_write_io_error(). This race
can lead to mark_buffer_write_io_error() either hitting NULL pointer
reference or trying to operate on already freed inode. Protect the
mapping handling with RCU to make sure mmb and inode aren't freed before
we are done with them.

Reported-by: Sashiko <sashiko-bot@kernel.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20260727104923.3828017-22-jack@suse.cz
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
fs/buffer.c