]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
accel/ethosu: fix wrong weight index in NPU_SET_SCALE1_LENGTH on U85
authorMuhammad Bilal <meatuni001@gmail.com>
Sat, 23 May 2026 21:07:53 +0000 (21:07 +0000)
committerRob Herring (Arm) <robh@kernel.org>
Thu, 4 Jun 2026 22:41:46 +0000 (17:41 -0500)
commite703843f242b28e35ac79408de571ae110c740b5
tree16983ee5971b0c0d110abb3555df806b33dd5e7e
parentef911805d86a05363d3ec2fa9835a41def83bb7e
accel/ethosu: fix wrong weight index in NPU_SET_SCALE1_LENGTH on U85

On non-U65 hardware (e.g. U85), opcode 0x4093 is NPU_SET_WEIGHT2_LENGTH.
The BASE handler for the same opcode correctly assigns to
st.weight[2].base, but the LENGTH handler mistakenly assigns cmds[1]
to st.weight[1].length instead of st.weight[2].length.

This leaves weight[2].length at its initialised sentinel value of
0xffffffff and corrupts weight[1].length with the user-supplied value,
breaking the software bounds-check state for both weight buffers on U85.

Fix the index to match the BASE handler.

Fixes: 5a5e9c0228e6 ("accel: Add Arm Ethos-U NPU driver")
Cc: stable@vger.kernel.org
Signed-off-by: Muhammad Bilal <meatuni001@gmail.com>
Link: https://patch.msgid.link/20260523210840.92039-3-meatuni001@gmail.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/accel/ethosu/ethosu_gem.c