]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
staging: nvec: fix unconditional pm_power_off teardown
authorAlexandru Hossu <hossu.alexandru@gmail.com>
Mon, 27 Apr 2026 08:17:13 +0000 (10:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 May 2026 14:17:10 +0000 (16:17 +0200)
commitfb2ae75b1ae5cffa11309b9ebf27aa4a2ceff9bd
tree2af36515756398249bc9b68caaf22ad2528a6284
parent26813881181deb3a32fbb59eadb2599cbe8423f6
staging: nvec: fix unconditional pm_power_off teardown

tegra_nvec_remove() unconditionally sets pm_power_off = NULL, even if
nvec was not the one that registered it. This breaks any other driver
that may have set pm_power_off to its own handler.

Replace the unconditional assignment with a guarded check so that
pm_power_off is only cleared if nvec was the one that set it.

Also remove the stale FIXME comment, as the guard addresses exactly
what it was asking for.

Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>
Link: https://patch.msgid.link/20260427081713.3401874-3-hossu.alexandru@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/nvec/nvec.c