]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/bridge: analogix_dp: Extract error pointer from correct variable
authorEthan Tidmore <ethantidmore06@gmail.com>
Wed, 29 Apr 2026 03:08:40 +0000 (22:08 -0500)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Mon, 4 May 2026 06:59:57 +0000 (08:59 +0200)
In devm_drm_panel_bridge_add() error path the pointer error should be
extracted from dp->plat_data->next_bridge but instead it is extracted
from bridge, which is a valid pointer and not part of this error path.

Extract error pointer from correct variable.

Detected by Smatch:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
warn: passing a valid pointer to 'PTR_ERR'

Fixes: 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Damon Ding <damon.ding@rock-chips.com>
Link: https://patch.msgid.link/20260429030840.704252-1-ethantidmore06@gmail.com
[Luca: add lkp report lines]
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605032334.MuQfn1mP-lkp@intel.com/
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

index 460729fdcecd944bbb6522d67f8370ca5cd07e59..3e46350170d4a824161a6535acadf94c086ad10a 100644 (file)
@@ -1486,7 +1486,7 @@ int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev)
                dp->plat_data->next_bridge = devm_drm_panel_bridge_add(dp->dev,
                                                                       dp->plat_data->panel);
                if (IS_ERR(dp->plat_data->next_bridge)) {
-                       ret = PTR_ERR(bridge);
+                       ret = PTR_ERR(dp->plat_data->next_bridge);
                        goto err_unregister_aux;
                }
        }