]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd/pm: remove trailing semicolon from AMDGPU_PM_POLICY_ATTR macro
authorYang Wang <kevinyang.wang@amd.com>
Wed, 18 Mar 2026 00:58:07 +0000 (20:58 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 24 Apr 2026 14:48:09 +0000 (10:48 -0400)
macros should not include a trailing semicolon as per kernel coding
style (checkpatch.pl warning).

move the semicolon from the macro definition to the invocation sites instead.

checkpatch.pl logs:
WARNING: macros should not use a trailing semicolon
+#define AMDGPU_PM_POLICY_ATTR(_name, _id)                                  \
+       static struct amdgpu_pm_policy_attr pm_policy_attr_##_name = {     \
+               .dev_attr = __ATTR(_name, 0644, amdgpu_get_pm_policy_attr, \
+                                  amdgpu_set_pm_policy_attr),             \
+               .id = PP_PM_POLICY_##_id,                                  \
+       };

Fixes: 4d154b1ca580 ("drm/amd/pm: Add support for DPM policies")
Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/amdgpu_pm.c

index 736304e73ca4d17aa6c51930a734af338409f7f6..024bfdb7c1571c24f3b4b42625025eaf57b9e0fe 100644 (file)
@@ -2505,12 +2505,12 @@ static ssize_t amdgpu_set_pm_policy_attr(struct device *dev,
                .dev_attr = __ATTR(_name, 0644, amdgpu_get_pm_policy_attr, \
                                   amdgpu_set_pm_policy_attr),             \
                .id = PP_PM_POLICY_##_id,                                  \
-       };
+       }
 
 #define AMDGPU_PM_POLICY_ATTR_VAR(_name) pm_policy_attr_##_name.dev_attr.attr
 
-AMDGPU_PM_POLICY_ATTR(soc_pstate, SOC_PSTATE)
-AMDGPU_PM_POLICY_ATTR(xgmi_plpd, XGMI_PLPD)
+AMDGPU_PM_POLICY_ATTR(soc_pstate, SOC_PSTATE);
+AMDGPU_PM_POLICY_ATTR(xgmi_plpd, XGMI_PLPD);
 
 static struct attribute *pm_policy_attrs[] = {
        &AMDGPU_PM_POLICY_ATTR_VAR(soc_pstate),