]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
RDMA/cma: Fix hardware address comparison length in netevent callback
authorOr Gerlitz <ogerlitz@ddn.com>
Wed, 17 Jun 2026 11:21:05 +0000 (14:21 +0300)
committerLeon Romanovsky <leon@kernel.org>
Thu, 2 Jul 2026 11:03:46 +0000 (07:03 -0400)
The cited commit hardcoded the hardware address comparison len to ETH_ALEN.

This breaks IPoIB, which uses 20-byte addresses. By truncating the
memcmp, the CMA may incorrectly assume the target address is
unchanged and fails to abort the stalled connection.

Fix this by replacing ETH_ALEN with the dynamic neigh->dev->addr_len
to correctly evaluate the full address regardless of the link layer.

Fixes: 925d046e7e52 ("RDMA/core: Add a netevent notifier to cma")
Signed-off-by: Or Gerlitz <ogerlitz@ddn.com>
Link: https://patch.msgid.link/20260617-fix-cma-ipoib-v1-1-03f869344304@ddn.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/core/cma.c

index 9480d1a51c116ef088277983175a11ca5c898d58..e88d3efb967b3bb59ea91f8a37445b769cd91e7c 100644 (file)
@@ -5270,7 +5270,7 @@ static int cma_netevent_callback(struct notifier_block *self,
 
        list_for_each_entry(current_id, &ips_node->id_list, id_list_entry) {
                if (!memcmp(current_id->id.route.addr.dev_addr.dst_dev_addr,
-                          neigh->ha, ETH_ALEN))
+                          neigh->ha, neigh->dev->addr_len))
                        continue;
                cma_id_get(current_id);
                if (!queue_work(cma_wq, &current_id->id.net_work))