]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
firmware: arm_ffa: Treat missing FF-A feature on a platform as a probe miss
authorSudeep Holla <sudeep.holla@kernel.org>
Tue, 26 May 2026 10:36:49 +0000 (11:36 +0100)
committerSudeep Holla <sudeep.holla@kernel.org>
Wed, 27 May 2026 09:14:23 +0000 (10:14 +0100)
When FF-A initialisation is driven from a platform device probe, systems
that do not implement FF-A can return -EOPNOTSUPP from the early transport
or version discovery paths. Driver core treats that as a matched probe
failure and prints:

  |  arm-ffa arm-ffa: probe with driver arm-ffa failed with error -95

That is noisy for a firmware interface that can be absent on otherwise
valid systems. Driver core already treats -ENODEV and -ENXIO as quiet
rejected matches, so translate only the early unsupported discovery cases
to -ENODEV. Keep later setup failures unchanged so real FF-A
initialisation problems are still reported as probe failures.

Reported-by: Nathan Chancellor <nathan@kernel.org>
Closes: https://lore.kernel.org/all/20260523001148.GA1319283@ax162
Reviewed-by: Yeoreum Yun <yeoreum.yun@arm.com>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Link: https://patch.msgid.link/20260526103649.5684-1-sudeep.holla@kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
drivers/firmware/arm_ffa/driver.c

index 54984e1b97413eb9fea10f75f7d49a070331c578..0f468362c288588e588a692fd30ce0c99f79d381 100644 (file)
@@ -2109,7 +2109,7 @@ static int ffa_probe(struct platform_device *pdev)
 
        ret = ffa_transport_init(&invoke_ffa_fn);
        if (ret)
-               return ret;
+               return ret == -EOPNOTSUPP ? -ENODEV : ret;
 
        drv_info = kzalloc_obj(*drv_info);
        if (!drv_info)
@@ -2117,8 +2117,11 @@ static int ffa_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, drv_info);
 
        ret = ffa_version_check(&drv_info->version);
-       if (ret)
+       if (ret) {
+               if (ret == -EOPNOTSUPP)
+                       ret = -ENODEV;
                goto free_drv_info;
+       }
 
        if (ffa_id_get(&drv_info->vm_id)) {
                pr_err("failed to obtain VM id for self\n");