]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/panfrost: Drop redundant optional clock checks in runtime PM
authorBiju Das <biju.das.jz@bp.renesas.com>
Fri, 20 Mar 2026 16:41:48 +0000 (16:41 +0000)
committerAdrián Larumbe <adrian.larumbe@collabora.com>
Fri, 27 Mar 2026 02:06:42 +0000 (02:06 +0000)
The clk_enable() and clk_disable() APIs already handle NULL clock pointers
gracefully — clk_enable() returns 0 and clk_disable() returns immediately
when passed a NULL or optional clock. The explicit if (pfdev->bus_clock)
guards around these calls in the runtime suspend/resume paths are
therefore unnecessary. Remove them to simplify the code.

Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Adrián Larumbe <adrian.larumbe@collabora.com>
Link: https://patch.msgid.link/20260320164158.487406-3-biju.das.jz@bp.renesas.com
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
drivers/gpu/drm/panfrost/panfrost_device.c

index dedc13e56631e131c0aac288175d6d7dedca7240..01e702a0b2f0707a6c948fb9df6161490e6c8fcf 100644 (file)
@@ -429,11 +429,9 @@ static int panfrost_device_runtime_resume(struct device *dev)
                if (ret)
                        goto err_clk;
 
-               if (pfdev->bus_clock) {
-                       ret = clk_enable(pfdev->bus_clock);
-                       if (ret)
-                               goto err_bus_clk;
-               }
+               ret = clk_enable(pfdev->bus_clock);
+               if (ret)
+                       goto err_bus_clk;
        }
 
        panfrost_device_reset(pfdev, true);
@@ -464,9 +462,7 @@ static int panfrost_device_runtime_suspend(struct device *dev)
        panfrost_gpu_power_off(pfdev);
 
        if (pfdev->comp->pm_features & BIT(GPU_PM_RT)) {
-               if (pfdev->bus_clock)
-                       clk_disable(pfdev->bus_clock);
-
+               clk_disable(pfdev->bus_clock);
                clk_disable(pfdev->clock);
                reset_control_assert(pfdev->rstc);
        }