]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/mchbar: Use intel_mchbar_read() instead of intel_de_read()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 31 Mar 2026 15:42:52 +0000 (18:42 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 1 Apr 2026 14:06:03 +0000 (17:06 +0300)
We are doing a few accesses to MCHBAR registers with intel_de_read().
Use the dedicated intel_mchbar_read() instead.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260331154259.24600-6-ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/display/intel_cdclk.c
drivers/gpu/drm/i915/display/intel_display_power.c

index 4a663dddf896436de67f3d2b029c0bd1c0340da2..835a332e968618a1f6bdc2d06add9045acdf431b 100644 (file)
@@ -41,6 +41,7 @@
 #include "intel_display_utils.h"
 #include "intel_display_wa.h"
 #include "intel_dram.h"
+#include "intel_mchbar.h"
 #include "intel_mchbar_regs.h"
 #include "intel_parent.h"
 #include "intel_pci_config.h"
@@ -376,8 +377,8 @@ static unsigned int intel_hpll_vco(struct intel_display *display)
        else
                return 0;
 
-       tmp = intel_de_read(display, display->platform.pineview ||
-                           display->platform.mobile ? HPLLVCO_MOBILE : HPLLVCO);
+       tmp = intel_mchbar_read(display, display->platform.pineview ||
+                               display->platform.mobile ? HPLLVCO_MOBILE : HPLLVCO);
 
        vco = vco_table[tmp & 0x7];
        if (vco == 0)
index b1c91de9d798bf7b5097d7c19f36242534b5e003..98e5a794fab7f40080dac9b84e50f4fdd88f77c0 100644 (file)
@@ -24,6 +24,7 @@
 #include "intel_display_wa.h"
 #include "intel_dmc.h"
 #include "intel_dram.h"
+#include "intel_mchbar.h"
 #include "intel_mchbar_regs.h"
 #include "intel_parent.h"
 #include "intel_pch_refclk.h"
@@ -1252,7 +1253,7 @@ static void assert_can_disable_lcpll(struct intel_display *display)
 static u32 hsw_read_dcomp(struct intel_display *display)
 {
        if (display->platform.haswell)
-               return intel_de_read(display, D_COMP_HSW);
+               return intel_mchbar_read(display, D_COMP_HSW);
        else
                return intel_de_read(display, D_COMP_BDW);
 }