media: vpif_capture: fix OF node reference imbalance

The driver reuses the OF node of the parent device but fails to take
another reference to balance the one dropped by the platform bus code
when unbinding the parent and releasing the child devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes: 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available")
Cc: stable@vger.kernel.org	# 4.13
Cc: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/platform/ti/davinci/vpif_capture.c b/drivers/media/platform/ti/davinci/vpif_capture.c
index 15df3ea2f77e12d2a28179a186fb05df34f996b4..91cb6223561a8ec224dec237cc6cec5c173d4655 100644 (file)
--- a/drivers/media/platform/ti/davinci/vpif_capture.c
+++ b/drivers/media/platform/ti/davinci/vpif_capture.c
@@ -1498,7 +1498,7 @@ vpif_capture_get_pdata(struct platform_device *pdev,
         * video ports & endpoints data.
         */
        if (pdev->dev.parent && pdev->dev.parent->of_node)
-               pdev->dev.of_node = pdev->dev.parent->of_node;
+               device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);
        if (!IS_ENABLED(CONFIG_OF) || !pdev->dev.of_node)
                return pdev->dev.platform_data;