]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: rtw89: fill VHT radiotap
authorPing-Ke Shih <pkshih@realtek.com>
Wed, 6 May 2026 13:09:53 +0000 (21:09 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Wed, 13 May 2026 03:36:01 +0000 (11:36 +0800)
Fill VHT radiotap by PHY status IE-09 which contains VHT SIG-A.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20260506131000.1706298-8-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/core.c
drivers/net/wireless/realtek/rtw89/core.h
drivers/net/wireless/realtek/rtw89/txrx.h

index a27e482e38a66b675a44caab10d930b6e0cc0428..2a9326335c5304063e476c183d5a7af21575ac30 100644 (file)
@@ -3176,6 +3176,50 @@ void rtw89_core_update_rx_status_by_ppdu(struct rtw89_dev *rtwdev,
                rx_status->enc_flags |= u8_encode_bits(1, RX_ENC_FLAG_STBC_MASK);
 }
 
+static void rtw89_core_update_radiotap_vht(struct rtw89_dev *rtwdev,
+                                          struct sk_buff *skb,
+                                          struct ieee80211_rx_status *rx_status,
+                                          struct rtw89_rx_phy_ppdu *phy_ppdu)
+{
+       const struct rtw89_phy_sts_ie09 *ie09;
+       struct ieee80211_radiotap_vht *vht;
+       u8 group_id;
+       u32 sig_a1;
+       u16 paid;
+       u8 nss;
+
+       if (!phy_ppdu)
+               return;
+
+       ie09 = phy_ppdu->ie09;
+       if (!ie09)
+               return;
+
+       vht = skb_push(skb, sizeof(*vht));
+       memset(vht, 0, sizeof(*vht));
+       rx_status->flag |= RX_FLAG_RADIOTAP_VHT;
+
+       sig_a1 = le64_get_bits(ie09->qw0, RTW89_PHY_STS_IE09_VHT_SIG_A1_MASK);
+
+       group_id = u32_get_bits(sig_a1, RTW89_PHY_STS_IE09_VHT_SIG_A1_GRP_ID);
+       vht->group_id = group_id;
+
+       if (group_id == 0 || group_id == 63) {
+               paid = u32_get_bits(sig_a1, RTW89_PHY_STS_IE09_VHT_SIG_A1_SU_PAID);
+               vht->partial_aid = cpu_to_le16(paid);
+       } else {
+               /* let mac80211 fill vht->mcs_nss[0] */
+#define WITH_MCS_IS_NOT_KNOWN(nss) ((nss) ? (15 << 4) | (nss) : 0)
+               nss = u32_get_bits(sig_a1, RTW89_PHY_STS_IE09_VHT_SIG_A1_MU_NSTS1);
+               vht->mcs_nss[1] = WITH_MCS_IS_NOT_KNOWN(nss);
+               nss = u32_get_bits(sig_a1, RTW89_PHY_STS_IE09_VHT_SIG_A1_MU_NSTS2);
+               vht->mcs_nss[2] = WITH_MCS_IS_NOT_KNOWN(nss);
+               nss = u32_get_bits(sig_a1, RTW89_PHY_STS_IE09_VHT_SIG_A1_MU_NSTS3);
+               vht->mcs_nss[3] = WITH_MCS_IS_NOT_KNOWN(nss);
+#undef WITH_MCS_IS_NOT_KNOWN
+       }
+}
+
 static void rtw89_core_update_radiotap_he(struct rtw89_dev *rtwdev,
                                          struct sk_buff *skb,
                                          struct ieee80211_rx_status *rx_status)
@@ -3266,12 +3310,15 @@ static void rtw89_core_update_radiotap_eht(struct rtw89_dev *rtwdev,
 
 static void rtw89_core_update_radiotap(struct rtw89_dev *rtwdev,
                                       struct sk_buff *skb,
-                                      struct ieee80211_rx_status *rx_status)
+                                      struct ieee80211_rx_status *rx_status,
+                                      struct rtw89_rx_phy_ppdu *phy_ppdu)
 {
        if (!(rtwdev->hw->conf.flags & IEEE80211_CONF_MONITOR))
                return;
 
-       if (rx_status->encoding == RX_ENC_HE)
+       if (rx_status->encoding == RX_ENC_VHT)
+               rtw89_core_update_radiotap_vht(rtwdev, skb, rx_status, phy_ppdu);
+       else if (rx_status->encoding == RX_ENC_HE)
                rtw89_core_update_radiotap_he(rtwdev, skb, rx_status);
        else if (rx_status->encoding == RX_ENC_EHT)
                rtw89_core_update_radiotap_eht(rtwdev, skb, rx_status);
@@ -3484,7 +3531,7 @@ static void rtw89_core_rx_to_mac80211(struct rtw89_dev *rtwdev,
        rtw89_core_hw_to_sband_rate(rx_status);
        rtw89_core_rx_stats(rtwdev, phy_ppdu, desc_info, skb_ppdu);
        rtw89_core_update_rx_status_by_ppdu(rtwdev, rx_status, phy_ppdu);
-       rtw89_core_update_radiotap(rtwdev, skb_ppdu, rx_status);
+       rtw89_core_update_radiotap(rtwdev, skb_ppdu, rx_status, phy_ppdu);
        rtw89_core_validate_rx_signal(rx_status);
        rtw89_core_update_rx_freq_from_ie(rtwdev, skb_ppdu, rx_status);
        rtw89_core_correct_mcc_chan(rtwdev, desc_info, rx_status, phy_ppdu);
index ca716e95cb2c4fa4a9a795c837318c8d64e39045..d1cd5997cf97312e25acff240bb2dc806879a905 100644 (file)
@@ -58,6 +58,7 @@ extern const struct ieee80211_ops rtw89_ops;
 #define RTW89_TX_DIV_RSSI_RAW_TH (2 << RSSI_FACTOR)
 #define DELTA_SWINGIDX_SIZE 30
 
+#define RTW89_RADIOTAP_ROOM_VHT sizeof(struct ieee80211_radiotap_vht)
 #define RTW89_RADIOTAP_ROOM_HE sizeof(struct ieee80211_radiotap_he)
 #define RTW89_RADIOTAP_ROOM_EHT \
        (sizeof(struct ieee80211_radiotap_tlv) + \
@@ -65,7 +66,8 @@ extern const struct ieee80211_ops rtw89_ops;
         sizeof(struct ieee80211_radiotap_tlv) + \
         ALIGN(sizeof(struct ieee80211_radiotap_eht_usig), 4))
 #define RTW89_RADIOTAP_ROOM \
-       ALIGN(max(RTW89_RADIOTAP_ROOM_HE, RTW89_RADIOTAP_ROOM_EHT), 64)
+       ALIGN(max3(RTW89_RADIOTAP_ROOM_VHT, RTW89_RADIOTAP_ROOM_HE, \
+                  RTW89_RADIOTAP_ROOM_EHT), 64)
 
 #define RTW89_HTC_MASK_VARIANT GENMASK(1, 0)
 #define RTW89_HTC_VARIANT_HE 3
index 18fe6d3d0f83a183dee835ad68a4f1a634e98801..ddf8742d6712f5f1ceba29d3e91d0165dbff9d0f 100644 (file)
@@ -662,6 +662,32 @@ struct rtw89_phy_sts_ie09 {
        __le64 qw0;
 } __packed;
 
+#define RTW89_PHY_STS_IE09_L_SIG_MASK GENMASK(21, 5) /* Legacy/VHT/HE L-SIG */
+#define RTW89_PHY_STS_IE09_L_SIG_RATE GENMASK(3, 0)
+#define RTW89_PHY_STS_IE09_L_SIG_RSVD BIT(4)
+#define RTW89_PHY_STS_IE09_L_SIG_LENGTH GENMASK(16, 5)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_MASK GENMASK_ULL(45, 22) /* VHT SIG-A1 */
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_BW GENMASK(1, 0)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_RSVD1 BIT(2)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_STBC BIT(3)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_GRP_ID GENMASK(9, 4)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_SU_NSTS GENMASK(12, 10)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_SU_PAID GENMASK(21, 13)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_MU_NSTS0 GENMASK(12, 10)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_MU_NSTS1 GENMASK(15, 13)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_MU_NSTS2 GENMASK(18, 16)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_MU_NSTS3 GENMASK(21, 19)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_TXOP_NOPS BIT(22)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A1_RSVD2 BIT(23)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A2_MASK GENMASK_ULL(55, 46) /* VHT SIG-A2 */
+#define RTW89_PHY_STS_IE09_VHT_SIG_A2_SGI BIT(0)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A2_SGI_DISA BIT(1)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A2_SUMU_CODE0 BIT(2)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A2_LDPC BIT(3)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A2_SUMU_CODE3 GENMASK(7, 4)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A2_BF BIT(8)
+#define RTW89_PHY_STS_IE09_VHT_SIG_A2_RSVD3 BIT(9)
+
 struct rtw89_phy_sts_ie10 {
        __le64 qw0;
        u8 sigb[];