]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
staging: sm750fb: return -ETIMEDOUT on timeout in de_wait functions
authorHungyu Lin <dennylin0707@gmail.com>
Mon, 27 Apr 2026 05:46:56 +0000 (05:46 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 May 2026 14:15:47 +0000 (16:15 +0200)
The hw_sm750le_de_wait() and hw_sm750_de_wait() functions return -1
when a timeout occurs. Replace these with -ETIMEDOUT to use a proper
errno value and better describe the error condition.

All callers check the return value as non-zero, so this change does
not alter existing behavior.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Link: https://patch.msgid.link/20260427054657.758-2-dennylin0707@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm750fb/sm750_hw.c

index 79e6344a729f02a6e02e5a5dcc5be15bf509fee1..beef05ded98d81b9f529b5e0da3af6793afc10ae 100644 (file)
@@ -501,8 +501,8 @@ int hw_sm750le_de_wait(void)
                    (DE_STATE2_DE_FIFO_EMPTY | DE_STATE2_DE_MEM_FIFO_EMPTY))
                        return 0;
        }
-       /* timeout error */
-       return -1;
+
+       return -ETIMEDOUT;
 }
 
 int hw_sm750_de_wait(void)
@@ -519,8 +519,8 @@ int hw_sm750_de_wait(void)
                    (SYSTEM_CTRL_DE_FIFO_EMPTY | SYSTEM_CTRL_DE_MEM_FIFO_EMPTY))
                        return 0;
        }
-       /* timeout error */
-       return -1;
+
+       return -ETIMEDOUT;
 }
 
 int hw_sm750_pan_display(struct lynxfb_crtc *crtc,