Fix memory leak and deadlock on error path in cache module

diff --git a/src/modules/rlm_cache/rlm_cache.c b/src/modules/rlm_cache/rlm_cache.c
index 581102dd54a6dcfe4c946c76ed9c96dd4ec5be12..98535fbbf7c2259956196e01366cad486d050719 100644 (file)
--- a/src/modules/rlm_cache/rlm_cache.c
+++ b/src/modules/rlm_cache/rlm_cache.c
@@ -958,6 +958,9 @@ xlat_action_t cache_xlat(TALLOC_CTX *ctx, fr_dcursor_t *out,
                if (unlikely(fr_value_box_copy(vb, vb, tmpl_value(map->rhs)) < 0)) {
                        RPEDEBUG("Failed copying value from cache entry");
                        talloc_free(vb);
+                       talloc_free(target);
+                       cache_free(inst, &c);
+                       cache_release(inst, request, &handle);
                        return XLAT_ACTION_FAIL;
                }
                fr_dcursor_append(out, vb);