]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
USB: gadget: snps-udc: fix device name leak on probe failure
authorJohan Hovold <johan@kernel.org>
Thu, 2 Jul 2026 14:15:34 +0000 (16:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Jul 2026 05:10:11 +0000 (07:10 +0200)
The gadget device name is set by UDC core when registering the gadget
and must not be set before to avoid leaking the name in intermediate
error paths (e.g. when detecting an older chip revision).

Fixes: 12ad0fcaf2fb ("usb: gadget: amd5536udc: let udc-core manage gadget->dev")
Cc: stable <stable@kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260702141536.90887-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/snps_udc_core.c

index 0e0db68e0b27a2ff9f0b9f1a87c4e26f14da52eb..d506f9d92bcad21256cd3fd910563e45d78d8c87 100644 (file)
@@ -3133,7 +3133,6 @@ int udc_probe(struct udc *dev)
        /* device struct setup */
        dev->gadget.ops = &udc_ops;
 
-       dev_set_name(&dev->gadget.dev, "gadget");
        dev->gadget.name = name;
        dev->gadget.max_speed = USB_SPEED_HIGH;