]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/dumb-buffer: Drop buffer-size limits for now
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 2 Jun 2026 11:24:01 +0000 (13:24 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Wed, 3 Jun 2026 16:47:51 +0000 (18:47 +0200)
The size limits break some of the CI tests. So drop them for now. Keep
the other overflow tests from commit 5ab62dd3687b ("drm: prevent integer
overflows in dumb buffer creation helpers") in place.

There is still a pre-existing overflow check for 32-bit type limits in
drm_mode_create_dumb() that will catch the really absurd size requests.
Drivers that still do not use drm_mode_size_dumb() should be updated. The
helper calculates dumb-buffer geometry with overflow checks.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 5ab62dd3687b ("drm: prevent integer overflows in dumb buffer creation helpers")
Reported-by: Jani Nikula <jani.nikula@linux.intel.com>
Closes: https://lore.kernel.org/dri-devel/ddf0233e50044059c85279f928661563ef6a55bf@intel.com/
Cc: Rajat Gupta <rajat.gupta@oss.qualcomm.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patch.msgid.link/20260602112842.252279-1-tzimmermann@suse.de
drivers/gpu/drm/drm_dumb_buffers.c

index cc99681a9ed0bcab598ca99ca8d5ce95290dd998..2156dbe601c9c4d59765524642d57c53da345cf1 100644 (file)
@@ -202,13 +202,6 @@ int drm_mode_create_dumb(struct drm_device *dev,
        if (!args->width || !args->height || !args->bpp)
                return -EINVAL;
 
-       /* Reject unreasonable inputs early.  Dumb buffers are for software
-        * rendering; nothing legitimate needs more than 8192x8192 at 32bpp.
-        * This prevents overflows in downstream alignment helpers.
-        */
-       if (args->width >= 8192 || args->height >= 8192 || args->bpp > 32)
-               return -EINVAL;
-
        /* overflow checks for 32bit size calculations */
        if (args->bpp > U32_MAX - 8)
                return -EINVAL;