]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
m68k: coldfire: fix breakage of missed IO access update
authorGreg Ungerer <gerg@linux-m68k.org>
Sun, 19 Jul 2026 13:11:11 +0000 (23:11 +1000)
committerGreg Ungerer <gerg@kernel.org>
Mon, 20 Jul 2026 00:20:53 +0000 (10:20 +1000)
Fix the last remaining breakage caused by missing a SoC IO access
update. Commit e1f3a00670d1 ("m68k: coldfire: use ColdFire specifc
IO access in SoC code") missed this read16() call which should be
mcf_read16().

Fixes: e1f3a00670d1 ("m68k: coldfire: use ColdFire specifc IO access in SoC code")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202607180731.U4tiwFcQ-lkp@intel.com/
Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
arch/m68k/coldfire/m528x.c

index 3383b1ba106a28143bb34cc8d2d9bd713f7fc6e5..f9874bba9e45f76c72aa5ddec9549a43b6420be7 100644 (file)
@@ -110,7 +110,7 @@ void wildfiremod_halt(void)
        printk(KERN_INFO "WildFireMod hibernating...\n");
 
        /* Set portE.5 to Digital IO */
-       mcf_write16(read16(MCFGPIO_PEPAR) & ~(1 << (5 * 2)), MCFGPIO_PEPAR);
+       mcf_write16(mcf_read16(MCFGPIO_PEPAR) & ~(1 << (5 * 2)), MCFGPIO_PEPAR);
 
        /* Make portE.5 an output */
        mcf_write8(mcf_read8(MCFGPIO_PDDR_E) | (1 << 5), MCFGPIO_PDDR_E);