packet_tracer: display icmp type and zero dst port (#5246)

diff --git a/src/packet_io/packet_tracer.cc b/src/packet_io/packet_tracer.cc
index fd8b17472a1444827362679413dcee82293a615a..9d02ea92c9a77ef4274ccaff2069d5f17c43f7cf 100644 (file)
--- a/src/packet_io/packet_tracer.cc
+++ b/src/packet_io/packet_tracer.cc
@@ -422,6 +422,13 @@ void PacketTracer::add_ip_header_info(const Packet& p)
     uint16_t sport = p.ptrs.sp;
     uint16_t dport = p.ptrs.dp;
 
+    if (p.type() == PktType::ICMP)
+    {
+        assert(p.ptrs.icmph);
+        sport = p.ptrs.icmph ? p.ptrs.icmph->type : 0;
+        dport = 0;
+    }
+
     const SfIp* actual_sip = p.ptrs.ip_api.get_src();
     const SfIp* actual_dip = p.ptrs.ip_api.get_dst();