]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: cs35l56-shared-test: Fix possible null pointer dereference
authorEthan Tidmore <ethantidmore06@gmail.com>
Sat, 23 May 2026 21:15:22 +0000 (16:15 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 26 May 2026 15:37:13 +0000 (16:37 +0100)
The struct regmap_config is dereferenced before its check. Also, after
it is checked priv->reg_offset is assigned to regmap_config->reg_base,
making the removed line redundant.

Detected by Smatch:
sound/soc/codecs/cs35l56-shared-test.c:681 cs35l56_shared_test_case_base_init()
warn: variable dereferenced before check 'regmap_config' (see line 665)

Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Link: https://patch.msgid.link/20260523211522.522616-1-ethantidmore06@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l56-shared-test.c

index 5b2b915559a99767d7346579b751f053a00dbfdf..4f52c8a192e551cc52b79f886ed5b040b20e8437 100644 (file)
@@ -662,7 +662,6 @@ static int cs35l56_shared_test_case_base_init(struct kunit *test, u8 type, u8 re
 
        test->priv = priv;
        priv->test = test;
-       priv->reg_offset = regmap_config->reg_base;
 
        /* Create dummy amp driver dev */
        priv->amp_dev = faux_device_create("cs35l56_shared_test_drv", NULL, NULL);