drm/colorop: Check if getting curve_1d_type default succeeds

Static analysis issue:

In all other uses of the function drm_object_property_get_default_value,
the return value of the function is checked before the output is saved to
the relevant object parameter.  Though likely unnecessary given the
execution path involved, keep the behavior consistent across uses and only
set colorop_state->curve_1d_type in __drm_colorop_state_reset if
drm_object_property_get_default_value succeeds.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Link: https://patch.msgid.link/20260202214709.8037-2-jonathan.cavitt@intel.com

diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c
index 566816e3c6f0c7d172534966fcfe56982e6505f3..764d120606665789b7ea5c07fa23bfddb47bf59a 100644 (file)
--- a/drivers/gpu/drm/drm_colorop.c
+++ b/drivers/gpu/drm/drm_colorop.c
@@ -516,10 +516,10 @@ static void __drm_colorop_state_reset(struct drm_colorop_state *colorop_state,
        colorop_state->bypass = true;
 
        if (colorop->curve_1d_type_property) {
-               drm_object_property_get_default_value(&colorop->base,
-                                                     colorop->curve_1d_type_property,
-                                                     &val);
-               colorop_state->curve_1d_type = val;
+               if (!drm_object_property_get_default_value(&colorop->base,
+                                                          colorop->curve_1d_type_property,
+                                                          &val))
+                       colorop_state->curve_1d_type = val;
        }
 }