Apply suggestions from code review

Co-authored-by: Remi Gacogne <github@coredump.fr>
Signed-off-by: Pieter Lexis <pieter@plexis.eu>

diff --git a/pdns/dnsdistdist/dnsdist-actions-factory.cc b/pdns/dnsdistdist/dnsdist-actions-factory.cc
index 5ae2f0f15fc914b64a33d5fa39bfea79773c797f..3654ab5fe985ee60e3b524d416312c602e5fe56d 100644 (file)
--- a/pdns/dnsdistdist/dnsdist-actions-factory.cc
+++ b/pdns/dnsdistdist/dnsdist-actions-factory.cc
@@ -533,7 +533,7 @@ public:
     try {
       DNSAction::Action result{};
       {
-        auto tracer = dnsquestion->ids.getTracer();
+        auto& tracer = dnsquestion->ids.getTracer();
         auto ret = pdns::trace::dnsdist::runWithLuaTracing(tracer, d_func, dnsquestion);
         if (ruleresult != nullptr) {
           if (std::optional<std::string> rule = std::get<1>(ret)) {
@@ -580,7 +580,7 @@ public:
     try {
       DNSResponseAction::Action result{};
       {
-        auto tracer = response->ids.getTracer();
+        auto& tracer = response->ids.getTracer();
         auto ret = pdns::trace::dnsdist::runWithLuaTracing(tracer, d_func, response);
         if (ruleresult != nullptr) {
           if (std::optional<std::string> rule = std::get<1>(ret)) {
@@ -630,7 +630,7 @@ public:
     try {
       DNSAction::Action result{};
       {
-        auto tracer = dnsquestion->ids.getTracer();
+        auto& tracer = dnsquestion->ids.getTracer();
         auto ret = pdns::trace::dnsdist::runWithLuaTracing(tracer, d_func, &dqffi);
         if (ruleresult != nullptr) {
           if (dqffi.result) {
@@ -693,7 +693,7 @@ public:
 
       dnsdist_ffi_dnsquestion_t dqffi(dnsquestion);
       int ret{0};
-      auto tracer = dnsquestion->ids.getTracer();
+      auto& tracer = dnsquestion->ids.getTracer();
       pdns::trace::dnsdist::runWithLuaTracing(state.d_luaContext, tracer, [&state, &dqffi, &ret]() {
         ret = state.d_func(&dqffi);
       });
@@ -757,7 +757,7 @@ public:
     try {
       DNSResponseAction::Action result{};
       {
-        auto tracer = response->ids.getTracer();
+        auto& tracer = response->ids.getTracer();
         auto ret = pdns::trace::dnsdist::runWithLuaTracing(tracer, d_func, &ffiResponse);
         if (ruleresult != nullptr) {
           if (ffiResponse.result) {
@@ -820,7 +820,7 @@ public:
 
       dnsdist_ffi_dnsresponse_t ffiResponse(response);
       int ret{0};
-      auto tracer = response->ids.getTracer();
+      auto& tracer = response->ids.getTracer();
       pdns::trace::dnsdist::runWithLuaTracing(state.d_luaContext, tracer, [&state, &ffiResponse, &ret]() {
         ret = state.d_func(&ffiResponse);
       });