]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
staging: rtl8723bs: remove wrapper rtw_hal_chip_configure()
authorNikolay Kulikov <nikolayof23@gmail.com>
Sun, 19 Apr 2026 07:19:27 +0000 (10:19 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Apr 2026 11:01:56 +0000 (05:01 -0600)
Remove the rtw_hal_chip_configure() function, as it's just a wrapper
that calls rtl8723bs_interface_configure() directly. Instead, call
rtl8723bs_interface_configure() from the appropriate places. This will
reduce code complexity and improve readability by removing unnecessary
abstraction.

Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
Link: https://patch.msgid.link/20260419072034.19824-2-nikolayof23@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/hal_intf.c
drivers/staging/rtl8723bs/include/hal_intf.h
drivers/staging/rtl8723bs/os_dep/sdio_intf.c

index 27c0c0198714fb69a21801c919c449f39d1c46a6..491208431396e64b627bfed3fc24897e6b718926 100644 (file)
@@ -7,11 +7,6 @@
 #include <drv_types.h>
 #include <hal_data.h>
 
-void rtw_hal_chip_configure(struct adapter *padapter)
-{
-       rtl8723bs_interface_configure(padapter);
-}
-
 void rtw_hal_read_chip_info(struct adapter *padapter)
 {
        ReadAdapterInfo8723BS(padapter);
index b193854bfe6e928efc45e7e92de29b8dbf94e4b1..7629cef95b0661bbebab9b1460c3addc869fa0cd 100644 (file)
@@ -195,7 +195,6 @@ void rtw_hal_get_hwreg(struct adapter *padapter, u8 variable, u8 *val);
 
 void rtw_hal_set_hwreg_with_buf(struct adapter *padapter, u8 variable, u8 *pbuf, int len);
 
-void rtw_hal_chip_configure(struct adapter *padapter);
 void rtw_hal_read_chip_info(struct adapter *padapter);
 void rtw_hal_read_chip_version(struct adapter *padapter);
 
index d0feb28b7043e2fdc5fe6c41da31120f05f74a53..f733692784bba192605d0e798356659a92e64020 100644 (file)
@@ -6,6 +6,7 @@
  ******************************************************************************/
 #include <drv_types.h>
 #include <hal_btcoex.h>
+#include <hal_data.h>
 #include <linux/jiffies.h>
 
 #ifndef dev_to_sdio_func
@@ -265,7 +266,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct
 
        rtw_hal_read_chip_version(padapter);
 
-       rtw_hal_chip_configure(padapter);
+       rtl8723bs_interface_configure(padapter);
 
        hal_btcoex_Initialize((void *)padapter);