]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: qcom: camss: Add debug message to camss-video format check
authorLoic Poulain <loic.poulain@oss.qualcomm.com>
Thu, 26 Feb 2026 09:08:50 +0000 (10:08 +0100)
committerBryan O'Donoghue <bod@kernel.org>
Fri, 8 May 2026 23:22:59 +0000 (00:22 +0100)
Add a debug trace to video_check_format() to log both the subdev-reported
format and the format requested by the video node. This makes it easier
to diagnose mismatches between subdev output and the negotiated V4L2
pixel format, as well as issues related to plane count, resolution, or
field settings.

Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
drivers/media/platform/qcom/camss/camss-video.c

index 831486e14754ab3a24b077e21be14ea3169220a4..f52d8e84f970d2ea5550a3a9160e90c58da49e01 100644 (file)
@@ -215,6 +215,12 @@ static int video_check_format(struct camss_video *video)
        if (ret < 0)
                return ret;
 
+       dev_dbg(video->camss->dev,
+               "%s: format is (%ux%u %p4cc/%up field:%u), trying (%ux%u %p4cc/%up field:%u)",
+                video->vdev.name, sd_pix->width, sd_pix->height, &sd_pix->pixelformat,
+                sd_pix->num_planes, sd_pix->field, pix->width, pix->height, &pix->pixelformat,
+                pix->num_planes, pix->field);
+
        if (pix->pixelformat != sd_pix->pixelformat ||
            pix->height != sd_pix->height ||
            pix->width != sd_pix->width ||