]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: aspeed: Fix missing __iomem annotation in output transfer path
authorChin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Fri, 22 May 2026 07:16:20 +0000 (15:16 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 22 May 2026 10:55:27 +0000 (11:55 +0100)
The dst parameter of aspeed_spi_user_transfer_tx() is an MMIO address
obtained from chip->ahb_base, but it was typed as void * instead of
void __iomem *.  This caused a sparse warning report. Fix the
parameter type to void __iomem * and drop the now-unnecessary
cast at the call site.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605180441.uD3toFRJ-lkp@intel.com/
Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Link: https://patch.msgid.link/20260522071621.102507-2-chin-ting_kuo@aspeedtech.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-aspeed-smc.c

index c21323e07d3cad5d0e1997022311e9d7408ab10b..808659a1f4601ccf73b8377614e01d1a9e897b3a 100644 (file)
@@ -891,7 +891,7 @@ static int aspeed_spi_user_unprepare_msg(struct spi_controller *ctlr,
 static void aspeed_spi_user_transfer_tx(struct aspeed_spi *aspi,
                                        struct spi_device *spi,
                                        const u8 *tx_buf, u8 *rx_buf,
-                                       void *dst, u32 len)
+                                       void __iomem *dst, u32 len)
 {
        const struct aspeed_spi_data *data = aspi->data;
        bool full_duplex_transfer = data->full_duplex && tx_buf == rx_buf;
@@ -936,7 +936,7 @@ static int aspeed_spi_user_transfer(struct spi_controller *ctlr,
                        aspeed_spi_set_io_mode(chip, CTRL_IO_QUAD_DATA);
 
                aspeed_spi_user_transfer_tx(aspi, spi, tx_buf, rx_buf,
-                                           (void *)ahb_base, xfer->len);
+                                           ahb_base, xfer->len);
        }
 
        if (rx_buf && rx_buf != tx_buf) {