]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
realtek: pcs: rtl931x: enable XSGMII setup 23674/head
authorJonas Jelonek <jelonek.jonas@gmail.com>
Fri, 5 Jun 2026 22:15:13 +0000 (22:15 +0000)
committerJonas Jelonek <jelonek.jonas@gmail.com>
Sat, 6 Jun 2026 07:54:58 +0000 (09:54 +0200)
The setup path has been adjusted before to at least not break a working
XSGMII setup. On the currently single affected device, the U-boot
pre-init runs unconditionally anyway. Thus, we can drop the top-level
gate and let our driver "setup" this mode. This enables further
structural changes.

Link: https://github.com/openwrt/openwrt/pull/23674
Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c

index 2a72117cbfb0310b680cd3407d316188b05c56c4..54d09d7fd3112515e757592e2b0902f7202f78ac 100644 (file)
@@ -3897,13 +3897,6 @@ static int rtpcs_931x_setup_serdes(struct rtpcs_serdes *sds,
        enum rtpcs_sds_media sds_media;
        int ret;
 
-       /*
-        * TODO: XSGMII (Realtek-proprietary 10G SGMII used by RTL8218D/E)
-        * bring-up is not implemented yet.
-        */
-       if (hw_mode == RTPCS_SDS_MODE_XSGMII)
-               return 0;
-
        rtpcs_931x_sds_deactivate(sds);
 
        ret = rtpcs_931x_sds_config_hw_mode(sds, hw_mode);