]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: Log device readiness timeouts as errors
authorBjorn Helgaas <helgaas@kernel.org>
Mon, 18 May 2026 19:12:18 +0000 (14:12 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 18 May 2026 22:26:58 +0000 (17:26 -0500)
pci_dev_wait() waits for a device to be Configuration-Ready after a reset,
such as a Function-Level Reset (FLR), a soft reset during a D3hot->
D0uninitialized transition when No_Soft_Reset == 0), or a power-up sequence
from D3cold->D0uninitialized.

If pci_dev_wait() returns success, the device is guaranteed to respond to
configuration requests with Successful Completion status.  If it times out,
device is completely non-responsive.

Upgrade the log level from pci_warn() to pci_err() to reflect this failure
state.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Rafael J. Wysocki (Intel) <rafael@kernel.org>
Link: https://patch.msgid.link/20260518191220.636213-2-bhelgaas@google.com
drivers/pci/pci.c

index 8f7cfcc000901d8fce9b9589cf38cbdbb8bd2912..5a9af0bb2c71cfbf37ac8469968a4851b55c2f60 100644 (file)
@@ -1253,8 +1253,8 @@ static int pci_dev_wait(struct pci_dev *dev, char *reset_type, int timeout)
                }
 
                if (delay > timeout) {
-                       pci_warn(dev, "not ready %dms after %s; giving up\n",
-                                delay - 1, reset_type);
+                       pci_err(dev, "not ready %dms after %s; giving up\n",
+                               delay - 1, reset_type);
                        return -ENOTTY;
                }