]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
USB: gadget: fsl-udc: fix device name leak on probe failure
authorJohan Hovold <johan@kernel.org>
Thu, 2 Jul 2026 14:15:33 +0000 (16:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Jul 2026 05:10:11 +0000 (07:10 +0200)
The gadget device name is set by UDC core when registering the gadget
and must not be set before to avoid leaking the name in intermediate
error paths (e.g. on dma pool creation failure).

Fixes: eab35c4e6d95 ("usb: gadget: fsl_udc_core: let udc-core manage gadget->dev")
Cc: stable <stable@kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260702141536.90887-2-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/fsl_udc_core.c

index 600ce8cc0fefc411b27fab17755a839c4e6ecc63..8c5b2f42ff44b1004eed1f2efba2c0e839613f9f 100644 (file)
@@ -2474,7 +2474,6 @@ static int fsl_udc_probe(struct platform_device *pdev)
        udc_controller->gadget.name = driver_name;
 
        /* Setup gadget.dev and register with kernel */
-       dev_set_name(&udc_controller->gadget.dev, "gadget");
        udc_controller->gadget.dev.of_node = pdev->dev.of_node;
 
        if (!IS_ERR_OR_NULL(udc_controller->transceiver))