]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
staging: rtl8723bs: make rtw_alloc_hwxmits static
authorHungyu Lin <dennylin0707@gmail.com>
Wed, 8 Apr 2026 11:13:10 +0000 (11:13 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Apr 2026 11:01:52 +0000 (05:01 -0600)
The rtw_alloc_hwxmits() function is only used within this file.
Make it static to limit its scope.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Link: https://patch.msgid.link/20260408111314.19329-3-dennylin0707@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_xmit.c
drivers/staging/rtl8723bs/include/rtw_xmit.h

index f64ec8e271edb52cca9b9238e5edfd7a32b5c1c0..b86c9c2f3b93b7145dc1c6454abd0d628948af31 100644 (file)
@@ -33,6 +33,46 @@ void _rtw_init_sta_xmit_priv(struct sta_xmit_priv *psta_xmitpriv)
        INIT_LIST_HEAD(&psta_xmitpriv->apsd);
 }
 
+static s32 rtw_alloc_hwxmits(struct adapter *padapter)
+{
+       struct hw_xmit *hwxmits;
+       struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
+
+       pxmitpriv->hwxmit_entry = HWXMIT_ENTRY;
+
+       pxmitpriv->hwxmits = NULL;
+
+       pxmitpriv->hwxmits = kzalloc_objs(*hwxmits, pxmitpriv->hwxmit_entry,
+                                         GFP_ATOMIC);
+       if (!pxmitpriv->hwxmits)
+               return _FAIL;
+
+       hwxmits = pxmitpriv->hwxmits;
+
+       if (pxmitpriv->hwxmit_entry == 5) {
+               hwxmits[0] .sta_queue = &pxmitpriv->bm_pending;
+
+               hwxmits[1] .sta_queue = &pxmitpriv->vo_pending;
+
+               hwxmits[2] .sta_queue = &pxmitpriv->vi_pending;
+
+               hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
+
+               hwxmits[4] .sta_queue = &pxmitpriv->be_pending;
+       } else if (pxmitpriv->hwxmit_entry == 4) {
+               hwxmits[0] .sta_queue = &pxmitpriv->vo_pending;
+
+               hwxmits[1] .sta_queue = &pxmitpriv->vi_pending;
+
+               hwxmits[2] .sta_queue = &pxmitpriv->be_pending;
+
+               hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
+       } else {
+       }
+
+       return _SUCCESS;
+}
+
 s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
 {
        int i;
@@ -1852,46 +1892,6 @@ exit:
        return res;
 }
 
-s32 rtw_alloc_hwxmits(struct adapter *padapter)
-{
-       struct hw_xmit *hwxmits;
-       struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
-
-       pxmitpriv->hwxmit_entry = HWXMIT_ENTRY;
-
-       pxmitpriv->hwxmits = NULL;
-
-       pxmitpriv->hwxmits = kzalloc_objs(*hwxmits, pxmitpriv->hwxmit_entry,
-                                         GFP_ATOMIC);
-       if (!pxmitpriv->hwxmits)
-               return _FAIL;
-
-       hwxmits = pxmitpriv->hwxmits;
-
-       if (pxmitpriv->hwxmit_entry == 5) {
-               hwxmits[0] .sta_queue = &pxmitpriv->bm_pending;
-
-               hwxmits[1] .sta_queue = &pxmitpriv->vo_pending;
-
-               hwxmits[2] .sta_queue = &pxmitpriv->vi_pending;
-
-               hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
-
-               hwxmits[4] .sta_queue = &pxmitpriv->be_pending;
-       } else if (pxmitpriv->hwxmit_entry == 4) {
-               hwxmits[0] .sta_queue = &pxmitpriv->vo_pending;
-
-               hwxmits[1] .sta_queue = &pxmitpriv->vi_pending;
-
-               hwxmits[2] .sta_queue = &pxmitpriv->be_pending;
-
-               hwxmits[3] .sta_queue = &pxmitpriv->bk_pending;
-       } else {
-       }
-
-       return _SUCCESS;
-}
-
 void rtw_free_hwxmits(struct adapter *padapter)
 {
        struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
index 544468f576924983edfcd5b11556534a153d4d01..b0189a703d2860dbb70dc9ae8254a19379389fc0 100644 (file)
@@ -457,7 +457,6 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter);
 void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv);
 
 
-s32 rtw_alloc_hwxmits(struct adapter *padapter);
 void rtw_free_hwxmits(struct adapter *padapter);