]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Merge patch series "vfs: call audit_inode_child() in lookup_open() on failure"
authorChristian Brauner <brauner@kernel.org>
Thu, 30 Jul 2026 10:16:56 +0000 (12:16 +0200)
committerChristian Brauner <brauner@kernel.org>
Thu, 30 Jul 2026 10:16:56 +0000 (12:16 +0200)
Jori Koolstra <jkoolstra@xs4all.nl> says:

While reworking lookup_open() to implement O_CREAT|O_DIRECTORY I came
across inconsistency in how audit_inode_child() is called in various
file create paths.

audit_inode_child() is called in may_create_dentry() so that failed
filesystem operations still register an audit entry. On success, the
entry is overwritten when, for instance, fsnotify_create() is called.
This is the calling convention in vfs_create() and vfs_mkdir().
In lookup_open(), however, when atomic_open() should have created a
file but didn't, no call to audit_inode_child() is made. The same is
true for the regular ->create() path.

On the suggestion of Christian, I am splitting this series from the
O_CREAT|O_DIRECTORY work, so that this can be discussed with the audit
people without delaying that work.

* patches from https://patch.msgid.link/20260710164233.827744-1-jkoolstra@xs4all.nl:
  fs/namei.c: update kerneldoc of atomic_open()
  vfs: call audit_inode_child() in lookup_open() on failure
  vfs: move create error && negative dentry case in lookup_open() up

Link: https://patch.msgid.link/20260710164233.827744-1-jkoolstra@xs4all.nl
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>

Trivial merge