]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
NFS: remove unused page and page2 in nfs4_replace_transport()
authorMike Rapoport (Microsoft) <rppt@kernel.org>
Sat, 23 May 2026 17:54:18 +0000 (20:54 +0300)
committerChristian Brauner <brauner@kernel.org>
Wed, 27 May 2026 13:12:23 +0000 (15:12 +0200)
Temporary buffers page and page2 allocated by nfs4_replace_transport() and
passed to nfs4_try_replacing_one_location() are never used.

Remove them and the code that allocates and frees memory for these buffers.

Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Link: https://patch.msgid.link/20260523-b4-fs-v1-6-275e36a83f0e@kernel.org
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
fs/nfs/nfs4namespace.c

index 14f72baf3b305bc2e967dacde1e46bdd335cea42..2a03f02bba7cef7a3bf62e3e1786ef54604da826 100644 (file)
@@ -481,7 +481,6 @@ int nfs4_submount(struct fs_context *fc, struct nfs_server *server)
  * Returns zero on success, or a negative errno value.
  */
 static int nfs4_try_replacing_one_location(struct nfs_server *server,
-               char *page, char *page2,
                const struct nfs4_fs_location *location)
 {
        struct net *net = rpc_net_ns(server->client);
@@ -541,21 +540,12 @@ static int nfs4_try_replacing_one_location(struct nfs_server *server,
 int nfs4_replace_transport(struct nfs_server *server,
                           const struct nfs4_fs_locations *locations)
 {
-       char *page = NULL, *page2 = NULL;
        int loc, error;
 
        error = -ENOENT;
        if (locations == NULL || locations->nlocations <= 0)
                goto out;
 
-       error = -ENOMEM;
-       page = (char *) __get_free_page(GFP_USER);
-       if (!page)
-               goto out;
-       page2 = (char *) __get_free_page(GFP_USER);
-       if (!page2)
-               goto out;
-
        for (loc = 0; loc < locations->nlocations; loc++) {
                const struct nfs4_fs_location *location =
                                                &locations->locations[loc];
@@ -564,14 +554,11 @@ int nfs4_replace_transport(struct nfs_server *server,
                    location->rootpath.ncomponents == 0)
                        continue;
 
-               error = nfs4_try_replacing_one_location(server, page,
-                                                       page2, location);
+               error = nfs4_try_replacing_one_location(server, location);
                if (error == 0)
                        break;
        }
 
 out:
-       free_page((unsigned long)page);
-       free_page((unsigned long)page2);
        return error;
 }