nvmet-tcp: check return value of nvmet_tcp_set_queue_sock

The return value of nvmet_tcp_set_queue_sock() is currently ignored in
nvmet_tcp_tls_handshake_done(). If it fails (e.g., due to the socket
not being in TCP_ESTABLISHED state), the socket callbacks will not be
properly set, leading to queue and socket leakage.

Fix this by capturing the return value and calling
nvmet_tcp_schedule_release_queue() on failure to ensure proper cleanup.

Fixes: 675b453e0241 ("nvmet-tcp: enable TLS handshake upcall")
Reviewed-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Signed-off-by: Keith Busch <kbusch@kernel.org>

diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
index 93b3c6134240a445f6ec79d722e706f109591625..3568fa9a09053d5f7fb5db930f974d7b15bb0371 100644 (file)
--- a/drivers/nvme/target/tcp.c
+++ b/drivers/nvme/target/tcp.c
@@ -1842,10 +1842,11 @@ static void nvmet_tcp_tls_handshake_done(void *data, int status,
        if (!status)
                status = nvmet_tcp_tls_key_lookup(queue, peerid);
 
+       if (!status)
+               status = nvmet_tcp_set_queue_sock(queue);
+
        if (status)
                nvmet_tcp_schedule_release_queue(queue);
-       else
-               nvmet_tcp_set_queue_sock(queue);
        kref_put(&queue->kref, nvmet_tcp_release_queue);
 }