]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
accel/amdxdna: Create common SMU interfaces for AIE2 and AIE4
authorDavid Zhang <yidong.zhang@amd.com>
Mon, 30 Mar 2026 16:37:04 +0000 (09:37 -0700)
committerLizhi Hou <lizhi.hou@amd.com>
Wed, 1 Apr 2026 17:44:51 +0000 (10:44 -0700)
AIE2 and AIE4 use similar interfaces to the SMU (System Management
Unit). Move the SMU implementation into aie_smu.c and provide common
interfaces for both platforms.

This allows AIE2 and AIE4 to share the same implementation and reduces
code duplication.

Co-developed-by: Hayden Laccabue <Hayden.Laccabue@amd.com>
Signed-off-by: Hayden Laccabue <Hayden.Laccabue@amd.com>
Signed-off-by: David Zhang <yidong.zhang@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Link: https://patch.msgid.link/20260330163705.3153647-6-lizhi.hou@amd.com
drivers/accel/amdxdna/Makefile
drivers/accel/amdxdna/aie.h
drivers/accel/amdxdna/aie2_pci.c
drivers/accel/amdxdna/aie2_pci.h
drivers/accel/amdxdna/aie2_smu.c [deleted file]
drivers/accel/amdxdna/aie_smu.c [new file with mode: 0644]
drivers/accel/amdxdna/npu1_regs.c
drivers/accel/amdxdna/npu4_regs.c

index d3c0fe765a8b3e08c2d536c49df36db245329db6..79369e497540d2549577bc4eb49fca648668321d 100644 (file)
@@ -3,12 +3,12 @@
 amdxdna-y := \
        aie.o \
        aie_psp.o \
+       aie_smu.o \
        aie2_ctx.o \
        aie2_error.o \
        aie2_message.o \
        aie2_pci.o \
        aie2_pm.o \
-       aie2_smu.o \
        aie2_solver.o \
        aie4_message.o \
        aie4_pci.o \
index 423ed34af9ee2c1d23a8742c0807909fc923b5ac..ba4c9ee21823daa77da7d3af5bcacd041cf1d8ce 100644 (file)
@@ -12,6 +12,7 @@
 #define AIE_TIMEOUT    1000000 /* us */
 
 struct psp_device;
+struct smu_device;
 
 struct aie_device {
        struct amdxdna_dev *xdna;
@@ -24,6 +25,7 @@ struct aie_device {
        unsigned long feature_mask;
 
        struct psp_device *psp_hdl;
+       struct smu_device *smu_hdl;
 };
 
 #define DECLARE_AIE_MSG(name, op) \
@@ -33,9 +35,21 @@ struct aie_device {
 #define PSP_REG_BAR(ndev, idx) ((ndev)->priv->psp_regs_off[(idx)].bar_idx)
 #define PSP_REG_OFF(ndev, idx) ((ndev)->priv->psp_regs_off[(idx)].offset)
 
+#define SMU_REG_BAR(ndev, idx) ((ndev)->priv->smu_regs_off[(idx)].bar_idx)
+#define SMU_REG_OFF(ndev, idx) ((ndev)->priv->smu_regs_off[(idx)].offset)
+
 #define DEFINE_BAR_OFFSET(reg_name, bar, reg_addr) \
        [reg_name] = {bar##_BAR_INDEX, (reg_addr) - bar##_BAR_BASE}
 
+enum smu_reg_idx {
+       SMU_CMD_REG = 0,
+       SMU_ARG_REG,
+       SMU_INTR_REG,
+       SMU_RESP_REG,
+       SMU_OUT_REG,
+       SMU_MAX_REGS /* Keep this at the end */
+};
+
 enum psp_reg_idx {
        PSP_CMD_REG = 0,
        PSP_ARG0_REG,
@@ -54,6 +68,10 @@ struct aie_bar_off_pair {
        u32     offset;
 };
 
+struct smu_config {
+       void __iomem    *smu_regs[SMU_MAX_REGS];
+};
+
 struct psp_config {
        const void              *fw_buf;
        u32                     fw_size;
@@ -76,4 +94,11 @@ int aie_psp_start(struct psp_device *psp);
 void aie_psp_stop(struct psp_device *psp);
 int aie_psp_waitmode_poll(struct psp_device *psp);
 
+/* aie_smu.c */
+struct smu_device *aiem_smu_create(struct drm_device *ddev, struct smu_config *conf);
+int aie_smu_init(struct smu_device *smu);
+void aie_smu_fini(struct smu_device *smu);
+int aie_smu_set_clocks(struct smu_device *smu, u32 *npuclk, u32 *hclk);
+int aie_smu_set_dpm(struct smu_device *smu, u32 dpm_level);
+
 #endif /* _AIE_H_ */
index 0489e668cd730aebdb59c81078e43473db421512..164e188ba501e479855cfe241ff8524f039da2aa 100644 (file)
@@ -282,6 +282,12 @@ static struct xrs_action_ops aie2_xrs_actions = {
        .set_dft_dpm_level = aie2_xrs_set_dft_dpm_level,
 };
 
+static void aie2_smu_fini(struct amdxdna_dev_hdl *ndev)
+{
+       ndev->priv->hw_ops.set_dpm(ndev, 0);
+       aie_smu_fini(ndev->aie.smu_hdl);
+}
+
 static void aie2_hw_stop(struct amdxdna_dev *xdna)
 {
        struct pci_dev *pdev = to_pci_dev(xdna->ddev.dev);
@@ -344,7 +350,7 @@ static int aie2_hw_start(struct amdxdna_dev *xdna)
                goto disable_dev;
        }
 
-       ret = aie2_smu_init(ndev);
+       ret = aie_smu_init(ndev->aie.smu_hdl);
        if (ret) {
                XDNA_ERR(xdna, "failed to init smu, ret %d", ret);
                goto free_channel;
@@ -464,6 +470,7 @@ static int aie2_init(struct amdxdna_dev *xdna)
        struct init_config xrs_cfg = { 0 };
        struct amdxdna_dev_hdl *ndev;
        struct psp_config psp_conf = { 0 };
+       struct smu_config smu_conf;
        const struct firmware *fw;
        unsigned long bars = 0;
        char *fw_full_path;
@@ -508,9 +515,10 @@ static int aie2_init(struct amdxdna_dev *xdna)
 
        for (i = 0; i < PSP_MAX_REGS; i++)
                set_bit(PSP_REG_BAR(ndev, i), &bars);
+       for (i = 0; i < SMU_MAX_REGS; i++)
+               set_bit(SMU_REG_BAR(ndev, i), &bars);
 
        set_bit(xdna->dev_info->sram_bar, &bars);
-       set_bit(xdna->dev_info->smu_bar, &bars);
        set_bit(xdna->dev_info->mbox_bar, &bars);
 
        for (i = 0; i < PCI_NUM_RESOURCES; i++) {
@@ -525,7 +533,6 @@ static int aie2_init(struct amdxdna_dev *xdna)
        }
 
        ndev->sram_base = tbl[xdna->dev_info->sram_bar];
-       ndev->smu_base = tbl[xdna->dev_info->smu_bar];
        ndev->mbox_base = tbl[xdna->dev_info->mbox_bar];
 
        ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
@@ -559,6 +566,15 @@ static int aie2_init(struct amdxdna_dev *xdna)
                ret = -ENOMEM;
                goto release_fw;
        }
+
+       for (i = 0; i < SMU_MAX_REGS; i++)
+               smu_conf.smu_regs[i] = tbl[SMU_REG_BAR(ndev, i)] + SMU_REG_OFF(ndev, i);
+       ndev->aie.smu_hdl = aiem_smu_create(&xdna->ddev, &smu_conf);
+       if (!ndev->aie.smu_hdl) {
+               XDNA_ERR(xdna, "failed to create smu");
+               ret = -ENOMEM;
+               goto release_fw;
+       }
        xdna->dev_handle = ndev;
 
        ret = aie2_hw_start(xdna);
index 4f036b9fa09686181d5d52de6f2071de103fa8ca..7c308672b5fe111699c7ee14a83ca28c4a6d8974 100644 (file)
 
 #define SRAM_REG_OFF(ndev, idx) ((ndev)->priv->sram_offs[(idx)].offset)
 
-#define SMU_REG(ndev, idx) \
-({ \
-       typeof(ndev) _ndev = ndev; \
-       ((_ndev)->smu_base + (_ndev)->priv->smu_regs_off[(idx)].offset); \
-})
 #define SRAM_GET_ADDR(ndev, idx) \
 ({ \
        typeof(ndev) _ndev = ndev; \
 })
 #endif
 
-enum aie2_smu_reg_idx {
-       SMU_CMD_REG = 0,
-       SMU_ARG_REG,
-       SMU_INTR_REG,
-       SMU_RESP_REG,
-       SMU_OUT_REG,
-       SMU_MAX_REGS /* Keep this at the end */
-};
-
 enum aie2_sram_reg_idx {
        MBOX_CHANN_OFF = 0,
        FW_ALIVE_OFF,
@@ -183,7 +169,6 @@ struct amdxdna_dev_hdl {
        struct aie_device               aie;
        const struct amdxdna_dev_priv   *priv;
        void                    __iomem *sram_base;
-       void                    __iomem *smu_base;
        void                    __iomem *mbox_base;
 
        u32                             total_col;
@@ -258,11 +243,6 @@ extern const struct dpm_clk_freq npu4_dpm_clk_table[];
 extern const struct rt_config npu1_default_rt_cfg[];
 extern const struct rt_config npu4_default_rt_cfg[];
 extern const struct amdxdna_fw_feature_tbl npu4_fw_feature_table[];
-
-/* aie2_smu.c */
-int aie2_smu_init(struct amdxdna_dev_hdl *ndev);
-void aie2_smu_fini(struct amdxdna_dev_hdl *ndev);
-int npu1_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level);
 int npu4_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level);
 
 /* aie2_pm.c */
diff --git a/drivers/accel/amdxdna/aie2_smu.c b/drivers/accel/amdxdna/aie2_smu.c
deleted file mode 100644 (file)
index 1b966bb..0000000
+++ /dev/null
@@ -1,156 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * Copyright (C) 2022-2024, Advanced Micro Devices, Inc.
- */
-
-#include <drm/drm_device.h>
-#include <drm/drm_gem_shmem_helper.h>
-#include <drm/drm_print.h>
-#include <drm/gpu_scheduler.h>
-#include <linux/iopoll.h>
-
-#include "aie2_pci.h"
-#include "amdxdna_pci_drv.h"
-
-#define SMU_RESULT_OK          1
-
-/* SMU commands */
-#define AIE2_SMU_POWER_ON              0x3
-#define AIE2_SMU_POWER_OFF             0x4
-#define AIE2_SMU_SET_MPNPUCLK_FREQ     0x5
-#define AIE2_SMU_SET_HCLK_FREQ         0x6
-#define AIE2_SMU_SET_SOFT_DPMLEVEL     0x7
-#define AIE2_SMU_SET_HARD_DPMLEVEL     0x8
-
-#define NPU4_DPM_TOPS(ndev, dpm_level) \
-({ \
-       typeof(ndev) _ndev = ndev; \
-       (4096 * (_ndev)->total_col * \
-        (_ndev)->priv->dpm_clk_tbl[dpm_level].hclk / 1000000); \
-})
-
-static int aie2_smu_exec(struct amdxdna_dev_hdl *ndev, u32 reg_cmd,
-                        u32 reg_arg, u32 *out)
-{
-       u32 resp;
-       int ret;
-
-       writel(0, SMU_REG(ndev, SMU_RESP_REG));
-       writel(reg_arg, SMU_REG(ndev, SMU_ARG_REG));
-       writel(reg_cmd, SMU_REG(ndev, SMU_CMD_REG));
-
-       /* Clear and set SMU_INTR_REG to kick off */
-       writel(0, SMU_REG(ndev, SMU_INTR_REG));
-       writel(1, SMU_REG(ndev, SMU_INTR_REG));
-
-       ret = readx_poll_timeout(readl, SMU_REG(ndev, SMU_RESP_REG), resp,
-                                resp, AIE_INTERVAL, AIE_TIMEOUT);
-       if (ret) {
-               XDNA_ERR(ndev->aie.xdna, "smu cmd %d timed out", reg_cmd);
-               return ret;
-       }
-
-       if (out)
-               *out = readl(SMU_REG(ndev, SMU_OUT_REG));
-
-       if (resp != SMU_RESULT_OK) {
-               XDNA_ERR(ndev->aie.xdna, "smu cmd %d failed, 0x%x", reg_cmd, resp);
-               return -EINVAL;
-       }
-
-       return 0;
-}
-
-int npu1_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level)
-{
-       u32 freq;
-       int ret;
-
-       ret = aie2_smu_exec(ndev, AIE2_SMU_SET_MPNPUCLK_FREQ,
-                           ndev->priv->dpm_clk_tbl[dpm_level].npuclk, &freq);
-       if (ret) {
-               XDNA_ERR(ndev->aie.xdna, "Set npu clock to %d failed, ret %d\n",
-                        ndev->priv->dpm_clk_tbl[dpm_level].npuclk, ret);
-               return ret;
-       }
-       ndev->npuclk_freq = freq;
-
-       ret = aie2_smu_exec(ndev, AIE2_SMU_SET_HCLK_FREQ,
-                           ndev->priv->dpm_clk_tbl[dpm_level].hclk, &freq);
-       if (ret) {
-               XDNA_ERR(ndev->aie.xdna, "Set h clock to %d failed, ret %d\n",
-                        ndev->priv->dpm_clk_tbl[dpm_level].hclk, ret);
-               return ret;
-       }
-
-       ndev->hclk_freq = freq;
-       ndev->max_tops = 2 * ndev->total_col;
-       ndev->curr_tops = ndev->max_tops * freq / 1028;
-
-       XDNA_DBG(ndev->aie.xdna, "MP-NPU clock %d, H clock %d\n",
-                ndev->npuclk_freq, ndev->hclk_freq);
-
-       return 0;
-}
-
-int npu4_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level)
-{
-       int ret;
-
-       ret = aie2_smu_exec(ndev, AIE2_SMU_SET_HARD_DPMLEVEL, dpm_level, NULL);
-       if (ret) {
-               XDNA_ERR(ndev->aie.xdna, "Set hard dpm level %d failed, ret %d ",
-                        dpm_level, ret);
-               return ret;
-       }
-
-       ret = aie2_smu_exec(ndev, AIE2_SMU_SET_SOFT_DPMLEVEL, dpm_level, NULL);
-       if (ret) {
-               XDNA_ERR(ndev->aie.xdna, "Set soft dpm level %d failed, ret %d",
-                        dpm_level, ret);
-               return ret;
-       }
-
-       ndev->npuclk_freq = ndev->priv->dpm_clk_tbl[dpm_level].npuclk;
-       ndev->hclk_freq = ndev->priv->dpm_clk_tbl[dpm_level].hclk;
-       ndev->max_tops = NPU4_DPM_TOPS(ndev, ndev->max_dpm_level);
-       ndev->curr_tops = NPU4_DPM_TOPS(ndev, dpm_level);
-
-       XDNA_DBG(ndev->aie.xdna, "MP-NPU clock %d, H clock %d\n",
-                ndev->npuclk_freq, ndev->hclk_freq);
-
-       return 0;
-}
-
-int aie2_smu_init(struct amdxdna_dev_hdl *ndev)
-{
-       int ret;
-
-       /*
-        * Failing to set power off indicates an unrecoverable hardware or
-        * firmware error.
-        */
-       ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_OFF, 0, NULL);
-       if (ret) {
-               XDNA_ERR(ndev->aie.xdna, "Access power failed, ret %d", ret);
-               return ret;
-       }
-
-       ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_ON, 0, NULL);
-       if (ret) {
-               XDNA_ERR(ndev->aie.xdna, "Power on failed, ret %d", ret);
-               return ret;
-       }
-
-       return 0;
-}
-
-void aie2_smu_fini(struct amdxdna_dev_hdl *ndev)
-{
-       int ret;
-
-       ndev->priv->hw_ops.set_dpm(ndev, 0);
-       ret = aie2_smu_exec(ndev, AIE2_SMU_POWER_OFF, 0, NULL);
-       if (ret)
-               XDNA_ERR(ndev->aie.xdna, "Power off failed, ret %d", ret);
-}
diff --git a/drivers/accel/amdxdna/aie_smu.c b/drivers/accel/amdxdna/aie_smu.c
new file mode 100644 (file)
index 0000000..62aea55
--- /dev/null
@@ -0,0 +1,153 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2026, Advanced Micro Devices, Inc.
+ */
+
+#include "drm/amdxdna_accel.h"
+#include <drm/drm_device.h>
+#include <drm/drm_managed.h>
+#include <drm/drm_print.h>
+#include <drm/gpu_scheduler.h>
+#include <linux/iopoll.h>
+
+#include "aie.h"
+
+#define SMU_RESULT_OK   1
+
+/* SMU commands */
+#define AIE_SMU_POWER_ON                0x3
+#define AIE_SMU_POWER_OFF               0x4
+#define AIE_SMU_SET_MPNPUCLK_FREQ       0x5
+#define AIE_SMU_SET_HCLK_FREQ           0x6
+#define AIE_SMU_SET_SOFT_DPMLEVEL       0x7
+#define AIE_SMU_SET_HARD_DPMLEVEL       0x8
+
+#define SMU_REG(s, reg) ((s)->smu_regs[reg])
+
+struct smu_device {
+       struct drm_device       *ddev;
+       struct smu_config       conf;
+       void __iomem            *smu_regs[SMU_MAX_REGS];
+};
+
+static int aie_smu_exec(struct smu_device *smu, u32 reg_cmd, u32 reg_arg, u32 *out)
+{
+       u32 resp;
+       int ret;
+
+       writel(0, SMU_REG(smu, SMU_RESP_REG));
+       writel(reg_arg, SMU_REG(smu, SMU_ARG_REG));
+       writel(reg_cmd, SMU_REG(smu, SMU_CMD_REG));
+
+       /* Clear and set SMU_INTR_REG to kick off */
+       writel(0, SMU_REG(smu, SMU_INTR_REG));
+       writel(1, SMU_REG(smu, SMU_INTR_REG));
+
+       ret = readx_poll_timeout(readl, SMU_REG(smu, SMU_RESP_REG), resp,
+                                resp, AIE_INTERVAL, AIE_TIMEOUT);
+       if (ret) {
+               drm_err(smu->ddev, "smu cmd %d timed out", reg_cmd);
+               return ret;
+       }
+
+       if (out)
+               *out = readl(SMU_REG(smu, SMU_OUT_REG));
+
+       if (resp != SMU_RESULT_OK) {
+               drm_err(smu->ddev, "smu cmd %d failed, 0x%x", reg_cmd, resp);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+int aie_smu_init(struct smu_device *smu)
+{
+       int ret;
+
+       /*
+        * Failing to set power off indicates an unrecoverable hardware or
+        * firmware error.
+        */
+       ret = aie_smu_exec(smu, AIE_SMU_POWER_OFF, 0, NULL);
+       if (ret) {
+               drm_err(smu->ddev, "Access power failed, ret %d", ret);
+               return ret;
+       }
+
+       ret = aie_smu_exec(smu, AIE_SMU_POWER_ON, 0, NULL);
+       if (ret) {
+               drm_err(smu->ddev, "Power on failed, ret %d", ret);
+               return ret;
+       }
+
+       return 0;
+}
+
+void aie_smu_fini(struct smu_device *smu)
+{
+       int ret;
+
+       ret = aie_smu_exec(smu, AIE_SMU_POWER_OFF, 0, NULL);
+       if (ret)
+               drm_err(smu->ddev, "Power off failed, ret %d", ret);
+}
+
+int aie_smu_set_clocks(struct smu_device *smu, u32 *npuclk, u32 *hclk)
+{
+       int ret;
+
+       if (npuclk) {
+               ret = aie_smu_exec(smu, AIE_SMU_SET_MPNPUCLK_FREQ, *npuclk, npuclk);
+               if (ret) {
+                       drm_err(smu->ddev, "Set mpnpu clock to %d failed, ret %d", *npuclk, ret);
+                       return ret;
+               }
+       }
+
+       if (hclk) {
+               ret = aie_smu_exec(smu, AIE_SMU_SET_HCLK_FREQ, *hclk, hclk);
+               if (ret) {
+                       drm_err(smu->ddev, "Set hclock to %d failed, ret %d",
+                               *hclk, ret);
+                       return ret;
+               }
+       }
+
+       return 0;
+}
+
+int aie_smu_set_dpm(struct smu_device *smu, u32 dpm_level)
+{
+       int ret;
+
+       ret = aie_smu_exec(smu, AIE_SMU_SET_HARD_DPMLEVEL, dpm_level, NULL);
+       if (ret) {
+               drm_err(smu->ddev, "Set hard dpm level %d failed, ret %d",
+                       dpm_level, ret);
+               return ret;
+       }
+
+       ret = aie_smu_exec(smu, AIE_SMU_SET_SOFT_DPMLEVEL, dpm_level, NULL);
+       if (ret) {
+               drm_err(smu->ddev, "Set soft dpm level %d failed, ret %d",
+                       dpm_level, ret);
+               return ret;
+       }
+
+       return 0;
+}
+
+struct smu_device *aiem_smu_create(struct drm_device *ddev, struct smu_config *conf)
+{
+       struct smu_device *smu;
+
+       smu = drmm_kzalloc(ddev, sizeof(*smu), GFP_KERNEL);
+       if (!smu)
+               return NULL;
+
+       smu->ddev = ddev;
+       memcpy(smu->smu_regs, conf->smu_regs, sizeof(smu->smu_regs));
+
+       return smu;
+}
index 2ea7568a2e995a7156f9d9be2cf319cc1ce6bb4d..a83e44f378ad9868546743e31690fa0bcd0fb0f2 100644 (file)
@@ -71,6 +71,27 @@ static const struct amdxdna_fw_feature_tbl npu1_fw_feature_table[] = {
        { 0 }
 };
 
+static int npu1_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level)
+{
+       u32 npuclk, hclk;
+       int ret;
+
+       npuclk = ndev->priv->dpm_clk_tbl[dpm_level].npuclk;
+       hclk = ndev->priv->dpm_clk_tbl[dpm_level].hclk;
+       ret = aie_smu_set_clocks(ndev->aie.smu_hdl, &npuclk, &hclk);
+       if (ret)
+               return ret;
+
+       ndev->npuclk_freq = npuclk;
+       ndev->hclk_freq = hclk;
+       ndev->max_tops = 2 * ndev->total_col;
+       ndev->curr_tops = ndev->max_tops * hclk / 1028;
+
+       XDNA_DBG(ndev->aie.xdna, "MP-NPU clock %d, H clock %d\n",
+                ndev->npuclk_freq, ndev->hclk_freq);
+       return 0;
+}
+
 static const struct amdxdna_dev_priv npu1_dev_priv = {
        .fw_path        = "amdnpu/1502_00/",
        .rt_config      = npu1_default_rt_cfg,
index 9689c56c83beb01fd216942acc16d7517daf4570..5d68171f4ec28c7b4807b908699656db71834072 100644 (file)
 #define NPU4_SMU_BAR_BASE      MMNPU_APERTURE4_BASE
 #define NPU4_SRAM_BAR_BASE     MMNPU_APERTURE1_BASE
 
+#define NPU4_DPM_TOPS(ndev, dpm_level) \
+({ \
+       typeof(ndev) _ndev = ndev; \
+       (4096 * (_ndev)->total_col * \
+        (_ndev)->priv->dpm_clk_tbl[dpm_level].hclk / 1000000); \
+})
+
 const struct rt_config npu4_default_rt_cfg[] = {
        { 5, 1, AIE2_RT_CFG_INIT }, /* PDI APP LOAD MODE */
        { 10, 1, AIE2_RT_CFG_INIT }, /* DEBUG BUF */
@@ -98,6 +105,25 @@ const struct amdxdna_fw_feature_tbl npu4_fw_feature_table[] = {
        { 0 }
 };
 
+int npu4_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level)
+{
+       int ret;
+
+       ret = aie_smu_set_dpm(ndev->aie.smu_hdl, dpm_level);
+       if (ret)
+               return ret;
+
+       ndev->npuclk_freq = ndev->priv->dpm_clk_tbl[dpm_level].npuclk;
+       ndev->hclk_freq = ndev->priv->dpm_clk_tbl[dpm_level].hclk;
+       ndev->max_tops = NPU4_DPM_TOPS(ndev, ndev->max_dpm_level);
+       ndev->curr_tops = NPU4_DPM_TOPS(ndev, dpm_level);
+
+       XDNA_DBG(ndev->aie.xdna, "MP-NPU clock %d, H clock %d\n",
+                ndev->npuclk_freq, ndev->hclk_freq);
+
+       return 0;
+}
+
 static const struct amdxdna_dev_priv npu4_dev_priv = {
        .fw_path        = "amdnpu/17f0_10/",
        .rt_config      = npu4_default_rt_cfg,