]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: rtw89: clear auto K delay value before downloading firmware
authorPing-Ke Shih <pkshih@realtek.com>
Fri, 15 May 2026 01:44:27 +0000 (09:44 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Mon, 25 May 2026 05:56:43 +0000 (13:56 +0800)
Once downloading firmware, do calibration on delay function to ensure
firmware can do proper delay for hardware IO.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20260515014433.16168-8-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/mac.c
drivers/net/wireless/realtek/rtw89/mac.h
drivers/net/wireless/realtek/rtw89/mac_be.c
drivers/net/wireless/realtek/rtw89/reg.h

index 87e3320b5a8105a2732ca3985e445f82c73fee48..6153162ad9b0b67091e820a36e5669c2f1527dde 100644 (file)
@@ -4318,6 +4318,8 @@ int rtw89_mac_partial_init(struct rtw89_dev *rtwdev, bool include_bb)
                        return ret;
        }
 
+       rtw89_mac_fwdl_preconfig(rtwdev);
+
        ret = rtw89_fw_download(rtwdev, RTW89_FW_NORMAL, include_bb);
        if (ret)
                return ret;
@@ -7477,6 +7479,7 @@ const struct rtw89_mac_gen_def rtw89_mac_gen_ax = {
 
        .reset_pwr_state = rtw89_mac_reset_pwr_state_ax,
        .disable_cpu = rtw89_mac_disable_cpu_ax,
+       .fwdl_preconfig = NULL,
        .fwdl_enable_wcpu = rtw89_mac_enable_cpu_ax,
        .fwdl_get_status = rtw89_fw_get_rdy_ax,
        .fwdl_check_path_ready = rtw89_fwdl_check_path_ready_ax,
index 75691a9549a77ddde19fc45d063229c1374319f7..69f8d7d818a0aa2befd9ceb38d9b26b6ae478e37 100644 (file)
@@ -1112,6 +1112,7 @@ struct rtw89_mac_gen_def {
 
        int (*reset_pwr_state)(struct rtw89_dev *rtwdev);
        void (*disable_cpu)(struct rtw89_dev *rtwdev);
+       void (*fwdl_preconfig)(struct rtw89_dev *rtwdev);
        int (*fwdl_enable_wcpu)(struct rtw89_dev *rtwdev, u8 boot_reason,
                                bool dlfw, bool include_bb);
        u8 (*fwdl_get_status)(struct rtw89_dev *rtwdev, enum rtw89_fwdl_check_type type);
@@ -1725,6 +1726,17 @@ static inline int rtw89_mac_efuse_read_ecv(struct rtw89_dev *rtwdev)
        return mac->efuse_read_ecv(rtwdev);
 }
 
+static inline
+void rtw89_mac_fwdl_preconfig(struct rtw89_dev *rtwdev)
+{
+       const struct rtw89_mac_gen_def *mac = rtwdev->chip->mac_def;
+
+       if (!mac->fwdl_preconfig)
+               return;
+
+       mac->fwdl_preconfig(rtwdev);
+}
+
 static inline
 void rtw89_fwdl_secure_idmem_share_mode(struct rtw89_dev *rtwdev, u8 mode)
 {
index dd0dbe78a1ed1e76f4711b8cef354ebfeda627f1..f24c119b99f1bd0b61b7168e4a7c7720e810c7c3 100644 (file)
@@ -622,6 +622,12 @@ static void rtw89_mac_disable_cpu_be(struct rtw89_dev *rtwdev)
        rtw89_write32(rtwdev, R_BE_UDM2, 0);
 }
 
+static void rtw89_mac_fwdl_preconfig_be(struct rtw89_dev *rtwdev)
+{
+       rtw89_write32_clr(rtwdev, R_BE_FW_AUTO_CAL_DELAY, B_BE_WCPU_FW_DELAY_COUNT_VALID);
+       rtw89_write32_mask(rtwdev, R_BE_FW_AUTO_CAL_DELAY, B_BE_WCPU_FW_DELAY_COUNT_MASK, 0);
+}
+
 static void set_cpu_en(struct rtw89_dev *rtwdev, bool include_bb)
 {
        u32 set = B_BE_WLANCPU_FWDL_EN;
@@ -3288,6 +3294,7 @@ const struct rtw89_mac_gen_def rtw89_mac_gen_be = {
 
        .reset_pwr_state = rtw89_mac_reset_pwr_state_be,
        .disable_cpu = rtw89_mac_disable_cpu_be,
+       .fwdl_preconfig = rtw89_mac_fwdl_preconfig_be,
        .fwdl_enable_wcpu = rtw89_mac_fwdl_enable_wcpu_be,
        .fwdl_get_status = fwdl_get_status_be,
        .fwdl_check_path_ready = rtw89_fwdl_check_path_ready_be,
index c9bfb163c32ecf3d773344684795c86b98a1af99..c2ffa6c196e46297158e634972ddb68a9090e753 100644 (file)
 
 #define R_BE_SECURE_BOOT_MALLOC_INFO 0x0184
 
+#define R_BE_FW_AUTO_CAL_DELAY 0x0188
+#define B_BE_WCPU_FW_DELAY_COUNT_VALID BIT(15)
+#define B_BE_WCPU_FW_DELAY_COUNT_MASK GENMASK(14, 0)
+
 #define R_BE_FWS0IMR 0x0190
 #define B_BE_FS_HALT_H2C_INT_EN BIT(31)
 #define B_BE_FS_FSM_HIOE_TO_EVENT_INT_EN BIT(30)