]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/panel/tdo-tl070wsh30: Use refcounted allocation in place of devm_kzalloc()
authorAlbert Esteve <aesteve@redhat.com>
Fri, 8 May 2026 07:04:46 +0000 (09:04 +0200)
committerMaxime Ripard <mripard@kernel.org>
Mon, 11 May 2026 07:14:19 +0000 (09:14 +0200)
Move to using the new API devm_drm_panel_alloc() to allocate the
panel. In the call to the new API, avoid using explicit type and use
__typeof() for more type safety.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patch.msgid.link/20260508-drm_panel_init_rm-v2-6-0bd4ac429971@redhat.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c

index 227f97f9b136f07c7c7ea8d8fd005261b878e5ca..13cfe252a838d55615895ff1e83e8a807548632b 100644 (file)
@@ -162,9 +162,6 @@ static int tdo_tl070wsh30_panel_add(struct tdo_tl070wsh30_panel *tdo_tl070wsh30)
                return err;
        }
 
-       drm_panel_init(&tdo_tl070wsh30->base, &tdo_tl070wsh30->link->dev,
-                      &tdo_tl070wsh30_panel_funcs, DRM_MODE_CONNECTOR_DSI);
-
        err = drm_panel_of_backlight(&tdo_tl070wsh30->base);
        if (err)
                return err;
@@ -183,10 +180,13 @@ static int tdo_tl070wsh30_panel_probe(struct mipi_dsi_device *dsi)
        dsi->format = MIPI_DSI_FMT_RGB888;
        dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_LPM;
 
-       tdo_tl070wsh30 = devm_kzalloc(&dsi->dev, sizeof(*tdo_tl070wsh30),
-                                   GFP_KERNEL);
-       if (!tdo_tl070wsh30)
-               return -ENOMEM;
+       tdo_tl070wsh30 = devm_drm_panel_alloc(&dsi->dev,
+                                             __typeof(*tdo_tl070wsh30), base,
+                                             &tdo_tl070wsh30_panel_funcs,
+                                             DRM_MODE_CONNECTOR_DSI);
+
+       if (IS_ERR(tdo_tl070wsh30))
+               return PTR_ERR(tdo_tl070wsh30);
 
        mipi_dsi_set_drvdata(dsi, tdo_tl070wsh30);
        tdo_tl070wsh30->link = dsi;