media: rockchip: rga: avoid odd frame sizes for YUV formats

Avoid odd frame sizes for YUV formats, as they may cause undefined
behavior. This is done in preparation for the RGA3, which hangs when the
output format is set to 129x129 pixel YUV420 SP (NV12).

This requirement is documented explicitly for the RGA3 in  section 5.6.3
of the RK3588 TRM Part 2. For the RGA2 the RK3588 TRM Part 2
(section 6.1.2) and RK3568 TRM Part 2 (section 14.2) only mentions the
x/y offsets and stride aligning requirements. But the vendor driver for
the RGA2 also contains checks for the width and height to be aligned to
2 bytes.

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
index f599c992829dd7efd8c4a0be4463100b33810a69..77b8c7ab74274b24f3d0a58d27a45f356ed68a75 100644 (file)
--- a/drivers/media/platform/rockchip/rga/rga.c
+++ b/drivers/media/platform/rockchip/rga/rga.c
@@ -337,6 +337,19 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
        struct rga_ctx *ctx = file_to_rga_ctx(file);
        const struct rga_hw *hw = ctx->rga->hw;
        struct rga_fmt *fmt;
+       struct v4l2_frmsize_stepwise frmsize = {
+               .min_width = hw->min_width,
+               .max_width = hw->max_width,
+               .min_height = hw->min_height,
+               .max_height = hw->max_height,
+               .step_width = 1,
+               .step_height = 1,
+       };
+
+       if (v4l2_is_format_yuv(v4l2_format_info(pix_fmt->pixelformat))) {
+               frmsize.step_width = 2;
+               frmsize.step_height = 2;
+       }
 
        if (V4L2_TYPE_IS_CAPTURE(f->type)) {
                const struct rga_frame *frm;
@@ -358,11 +371,7 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
        if (!fmt)
                fmt = &hw->formats[0];
 
-       pix_fmt->width = clamp(pix_fmt->width,
-                              hw->min_width, hw->max_width);
-       pix_fmt->height = clamp(pix_fmt->height,
-                               hw->min_height, hw->max_height);
-
+       v4l2_apply_frmsize_constraints(&pix_fmt->width, &pix_fmt->height, &frmsize);
        v4l2_fill_pixfmt_mp(pix_fmt, fmt->fourcc, pix_fmt->width, pix_fmt->height);
        pix_fmt->field = V4L2_FIELD_NONE;