times-tests: pacify -Wuseless-cast

* tests/test-times.c (tms2ms): New function.
(main): Use it to simplify printing and avoid need for casts.
Pacify -Wuseless-cast via compound literals.

diff --git a/ChangeLog b/ChangeLog
index ddbc4ad3814a982609996d003cf5bad092b2fc57..518d0bfe17d0b3c7ea12a8c4fc3aaa7bcb1d2b1f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2026-05-08  Paul Eggert  <eggert@cs.ucla.edu>
 
+       times-tests: pacify -Wuseless-cast
+       * tests/test-times.c (tms2ms): New function.
+       (main): Use it to simplify printing and avoid need for casts.
+       Pacify -Wuseless-cast via compound literals.
+
        strncat-tests: omit confusing casts
        * tests/test-strncpy.c (check): Omit no-op cast.
        * tests/unistr/test-strncat.h (check): Use better type for

diff --git a/tests/test-times.c b/tests/test-times.c
index b0370c7a68c43f591dc284526f7efd2c002c74a5..e37b629abd1f61bd2ad24f8c99377b94a85b9e0f 100644 (file)
--- a/tests/test-times.c
+++ b/tests/test-times.c
@@ -38,6 +38,12 @@ doublecmp (const void *p, const void *q)
   return a < b ? -1 : a > b ? 1 : 0;
 }
 
+static long int
+tms2ms (long int tms, clock_t clk_tck)
+{
+  return tms * 1000 / clk_tck;
+}
+
 int
 main (int argc, char *argv[])
 {
@@ -58,13 +64,13 @@ main (int argc, char *argv[])
 
   if (argc > 1)
     {
-      printf ("clk_tck %ld\n", (long int) clk_tck);
+      printf ("clk_tck %ld\n", (long int) {clk_tck});
 
-      printf ("t %ld\n", (long int) t);
-      printf ("tms.tms_utime %ldms\n", ((long int) tms.tms_utime * 1000) / (long int) clk_tck);
-      printf ("tms.tms_stime %ldms\n", ((long int) tms.tms_stime * 1000) / (long int) clk_tck);
-      printf ("tms.tms_cutime %ldms\n", ((long int) tms.tms_cutime * 1000) / (long int) clk_tck);
-      printf ("tms.tms_cstime %ldms\n", ((long int) tms.tms_cstime * 1000) / (long int) clk_tck);
+      printf ("t %ld\n", (long int) {t});
+      printf ("tms.tms_utime %ldms\n", tms2ms (tms.tms_utime, clk_tck));
+      printf ("tms.tms_stime %ldms\n", tms2ms (tms.tms_stime, clk_tck));
+      printf ("tms.tms_cutime %ldms\n", tms2ms (tms.tms_cutime, clk_tck));
+      printf ("tms.tms_cstime %ldms\n", tms2ms (tms.tms_cstime, clk_tck));
     }
 
   if (argc > 1)
@@ -91,13 +97,13 @@ main (int argc, char *argv[])
 
   if (argc > 1)
     {
-      printf ("clk_tck %ld\n", (long int) clk_tck);
+      printf ("clk_tck %ld\n", (long int) {clk_tck});
 
-      printf ("t %ld\n", (long int) t);
-      printf ("tms.tms_utime %ldms\n", ((long int) tms.tms_utime * 1000) / (long int) clk_tck);
-      printf ("tms.tms_stime %ldms\n", ((long int) tms.tms_stime * 1000) / (long int) clk_tck);
-      printf ("tms.tms_cutime %ldms\n", ((long int) tms.tms_cutime * 1000) / (long int) clk_tck);
-      printf ("tms.tms_cstime %ldms\n", ((long int) tms.tms_cstime * 1000) / (long int) clk_tck);
+      printf ("t %ld\n", (long int) {t});
+      printf ("tms.tms_utime %ldms\n", tms2ms (tms.tms_utime, clk_tck));
+      printf ("tms.tms_stime %ldms\n", tms2ms (tms.tms_stime, clk_tck));
+      printf ("tms.tms_cutime %ldms\n", tms2ms (tms.tms_cutime, clk_tck));
+      printf ("tms.tms_cstime %ldms\n", tms2ms (tms.tms_cstime, clk_tck));
     }
 
   return 0;